Overridden options are displayed with an icon to the left.
But the URL to the icon image, in the CSS, uses an absolute path, so it only works if Drupal was installed in the 'root' folder. I've installed my Drupal in a sub-folder, so my browser doesn't see the icon.
I'm attaching a fix.
I had to choose an icon --I assumed 'menu-leaf.gif' was temporary-- so I plucked a 'lock' icon from Tango's website. I think a lock analogy is clear: these settings are effectively locked: changing them in any other display doesn't affect them here.
So I'm attaching the 'lock.png' icon as well. Put it in the 'images' folder.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | overridden.gif | 175 bytes | webchick |
| #4 | views-overridden-icon-270854-4.patch | 698 bytes | webchick |
| #2 | scissors_alternative.png | 2.61 KB | mooffie |
| #1 | overridden_icon.diff | 764 bytes | mooffie |
| lock.png | 1.01 KB | mooffie |
Comments
Comment #1
mooffie commentedHmm... drupal.org didn't 'get' the attached patch. I'm attaching it here.
Comment #2
mooffie commentedBTW, I also contemplated the analogy of scissors: it's as if these settings are cut out from the 'defaults'. But I think a lock analogy is clearer. I'm attaching a scissors image; it's just for brainstorming. You can ignore this comment altogether.
Comment #3
webchickWe can't use Tango icons because they're not GPL. I'm not sure the analogy of "lock" or "scissors" really works here... the settings aren't locked; you can change them at any time. And scissors usually means cut/copy/paste in most applications, which doesn't map well to what overridden settings do.
I'm fine with just using the same dot, but it definitely needs to be included in the Views package and linked to from a relative path. I'm bumping this to a critical bug because without this visual indication, it is completely impossible to tell if your arguments/filters/etc. are overridden without clicking into every single section of every single display (or being /very/ observant and noticing the slight nudge to the right the section gets on the page).
Comment #4
webchickPatch.
Comment #5
mooffie commentedYour patch works.
Yes, I certainly agree it's "critical".
(My apologies for suggesting Tango: I didn't know it wasn't legit here.)
(I hate the hollow dot, but we must not delay commiting this patch. We can always improve the icon in a separate issue.)
Comment #6
merlinofchaos commentedInstead of marking overridden fields, I marked fields that are defaulted.
What's interesting is that this is actually closer to how it works in the code, and I think it turns out to be more obvious what's going on. We'll have to see with actual user use, of course. I'm sure some people will complain.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.