Closed (fixed)
Project:
Mollom
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
15 Jun 2008 at 21:22 UTC
Updated:
1 Jul 2008 at 03:12 UTC
Jump to comment: Most recent file
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | mollom_hook_uninstall_2.patch | 550 bytes | David_Rothstein |
| mollom_hook_uninstall.patch | 549 bytes | Gurpartap Singh |
Comments
Comment #1
David_Rothstein commentedNice, yeah, this is definitely needed.
I'm personally a little paranoid about wildcard variable deletion; it really doesn't take a whole lot for another module's variables to accidentally get deleted by code like this.... The attached version uses "mollom_%" rather than "mollom%" (which gives a bit more protection but not much).
A safer way would be to explicitly delete only the variables defined by this module, and use node_get_types() here -- as well as hook_node_type() in the main module -- to deal with cleaning up the variables whose names depend on the node type names. That would be both cleaner and safer... whether it's really worth the effort I'm not sure ;)
Comment #2
David_Rothstein commentedOops, here's the attachment.
Comment #3
David_Rothstein commentedAnd here it is for real. Firefox 3 is having some serious issues with drupal.org today...
Comment #4
David_Rothstein commentedThis is unbelievable... The file shows up in the preview comment but not in the final post. Looks like I might be filing a bug report after this ;)
Comment #5
dries commentedCommitted to DRUPAL-6. I've also backported the change to DRUPAL-5. Thanks all.
Comment #6
dries commentedComment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.