Comments

David_Rothstein’s picture

Nice, yeah, this is definitely needed.

I'm personally a little paranoid about wildcard variable deletion; it really doesn't take a whole lot for another module's variables to accidentally get deleted by code like this.... The attached version uses "mollom_%" rather than "mollom%" (which gives a bit more protection but not much).

A safer way would be to explicitly delete only the variables defined by this module, and use node_get_types() here -- as well as hook_node_type() in the main module -- to deal with cleaning up the variables whose names depend on the node type names. That would be both cleaner and safer... whether it's really worth the effort I'm not sure ;)

David_Rothstein’s picture

Oops, here's the attachment.

David_Rothstein’s picture

And here it is for real. Firefox 3 is having some serious issues with drupal.org today...

David_Rothstein’s picture

StatusFileSize
new550 bytes

This is unbelievable... The file shows up in the preview comment but not in the final post. Looks like I might be filing a bug report after this ;)

dries’s picture

Committed to DRUPAL-6. I've also backported the change to DRUPAL-5. Thanks all.

dries’s picture

Status: Needs review » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.