password preg too limiting

joestewart@drup... - June 16, 2008 - 20:07
Project:FeedBurner
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Dave Reid
Status:closed
Description

348 : if (!preg_match('/\\A\\w*\\z/', $value)) {

seems to be too strict in accepting passwords that are correct feedburner passwords and contain special characters.

#1

Shane Birley - July 23, 2008 - 18:26

I can verify this issue since I am forced to limit the passwords I use for Feedburner since the module errors out and doesn't accept the password special characters.

#2

Dave Reid - July 28, 2008 - 07:08
Assigned to:Anonymous» Dave Reid
Status:active» active (needs more info)

Do either of you know what kind of special characters are allowed?

#3

Shane Birley - July 28, 2008 - 15:42

Off the top of my head, I don't know which ones are allowed. To give you an idea, any passwords I use are generated via a tool like this: http://www.pctools.com/guides/password/

The passwords I generate from tools like this work with the Feedburner web site, but fail when I attempt to verify using the module.

Common characters like the following appear to be the issue as random passwords using only uppercase and lowercase characters work fine.

# @ ! $ % & * _ ? + = -

#4

Shane Birley - July 29, 2008 - 06:32

I also just did a bit of testing with password length and I don't see any problems there. But, again, only using upper and lowercase non-special characters.

#5

joestewart@drup... - August 28, 2008 - 15:05

No idea about what characters they accept. But that may be part of the issue.

Stepping back a little. This also seems more strict than what Drupal itself accepts. What is the goal for this?

Looking at the code in the D6 version. I guess this has been changed/removed?

#6

Dave Reid - September 2, 2008 - 05:45
Status:active (needs more info)» fixed

Yes I removed the code in the D6 version since right now FeedBurner is being merged to Google and the Feed Management API (which uses the account authorization) is not available. Once it becomes available again, I'll be able to code stuff that uses it. I'm going to mark this as fixed since a D5 revision will not include this code as well.

#7

Dave Reid - September 2, 2008 - 05:48

You can keep updated on the Feed Management API with #192906: support feedburner management api

#8

Anonymous (not verified) - September 16, 2008 - 05:52
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.