Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
node system
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Jun 2008 at 02:41 UTC
Updated:
14 Jul 2012 at 23:27 UTC
Jump to comment: Most recent file
Comments
Comment #1
stevenpatzComment #2
drewish commentedthe coding standards say false should be capitalized.
Comment #3
mvc@drewish: thanks for the comments. I've changed the capitalization, and generated a new patch against 7.x-dev.
Comment #4
chx commented// Validate the "authored on" field. As of PHP 5.1.0, strtotime returns FALSE instead of -1 upon failure.
Drupal 7 is PHP 5.2 only. You can simplify the condition and as a side affect get access to negative timestamps. Win-win.
Comment #5
mvc@chx: good catch. I've updated that now.
Comment #6
obsidiandesign commentedApplies correctly to HEAD. Tested with 1969-01-01 for authored date, and date is accepted into db & displays correctly. Also, all Node SimpleTests run successfully after applying this patch. +1 for RTBC.
Comment #7
Anonymous (not verified) commentedThe last submitted patch failed testing.
Comment #8
mvcThe status of this issue was never changed, but this fix is in DRUPAL-7-0-UNSTABLE-2 (which is why the patch currently fails automated testing), so I'm going to mark this issue fixed.