The attached patch adds PostgreSQL support to this module. It also changes the datatype of the "timestamp" field in the database (from int(10) to "int unsigned"/"int_unsigned") to conform to the way timestamps are stored in Drupal core.

CommentFileSizeAuthor
#3 currency_api.patch1.66 KBtr
#1 currency_api.patch1.67 KBtr
currency_api.patch1.16 KBtr

Comments

tr’s picture

tr commented
Version: master » 5.x-1.x-dev
StatusFileSize
new currency_api.patch1.67 KB

Wrong patch above - here's the right one.

kbahey’s picture

kbahey commented
Status: Active » Needs work

I am fine with this patch, except for the change for MySQL.

Making it a plain INT, like core does, is more consistent.

tr’s picture

tr commented
Status: Needs work » Needs review
StatusFileSize
new currency_api.patch1.66 KB

My mistake. I had searched the core .install files for "timestamp" and there were many results - the line I looked at said int unsigned, but I now see that the vast majority are plain int. It's interesting that core isn't completely consistent in its usage here. New patch attached.

kbahey’s picture

kbahey commented
Status: Needs review » Fixed

Committed.

You forgot the one in the update, still had unsigned, but I fixed it for you.

Thanks

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.