Two note:
1) You should provide theme_ functions to customize the voting mechanism for users.
2) You shouldn't do format strings into the t() function if it's not i18n sensitive, like this (line 253):
$o = t('<div id="nodevote vote">Please rate this node. 1 = worst score, 10 = best score<br/>');
The good practice is here:
$o = '<div id="nodevote vote">'.t('Please rate this node. 1 = worst score, 10 = best score').'<br />';
(The space before "/" in <br /> is important!)
If you mind, I try to help.
Bests,
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | nodevote_theme.patch | 1.58 KB | aries |
Comments
Comment #1
kbahey commentedThanks, they are valid points.
Please submit a patch, and I will apply it.
See the developer handbook on details on how to create and submit a patch.
Comment #2
aries commentedOk, I'll try to send a patch.
Comment #3
aries commentedHere is the patch. Suggestions are welcome. :)
--
Aries
http://aries.mindworks.hu
Comment #4
kbahey commentedPatch has been applied tro repository.
Many thanks.
Comment #5
(not verified) commentedComment #6
(not verified) commentedComment #7
(not verified) commentedComment #8
(not verified) commentedComment #9
(not verified) commented