Two note:

1) You should provide theme_ functions to customize the voting mechanism for users.
2) You shouldn't do format strings into the t() function if it's not i18n sensitive, like this (line 253):

 $o = t('<div id="nodevote vote">Please rate this node. 1 = worst score, 10 = best score<br/>');

The good practice is here:

 $o = '<div id="nodevote vote">'.t('Please rate this node. 1 = worst score, 10 = best score').'<br />';

(The space before "/" in <br /> is important!)

If you mind, I try to help.
Bests,

Aries
http://aries.mindworks.hu

CommentFileSizeAuthor
#3 nodevote_theme.patch1.58 KBaries

Comments

kbahey’s picture

Thanks, they are valid points.

Please submit a patch, and I will apply it.

See the developer handbook on details on how to create and submit a patch.

aries’s picture

Assigned: Unassigned » aries

Ok, I'll try to send a patch.

aries’s picture

StatusFileSize
new1.58 KB

Here is the patch. Suggestions are welcome. :)

--
Aries
http://aries.mindworks.hu

kbahey’s picture

Title: theme functions are rulez » Enhance theme functions
Status: Active » Fixed

Patch has been applied tro repository.

Many thanks.

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

Status: Fixed » Closed (fixed)