I'm glad the icons are more sane now for the hide/show pane stuff (thanks #253515: icon for show/hiding panes -- although there's a bug that the icons are currently reversed). However, it's still sort of easy to miss the fact that a pane is hidden. The editors on socialistworker.org proposed that I make hidden panes more obviously hidden by greying them out. See attached screenshot. Should I post a patch for this, or is this won't fix territory?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | panels-hidden-pane-colors.orig-hidden-hover.png | 14.65 KB | dww |
| #7 | panels-hidden-pane-colors.dww-hidden-hover.png | 14.62 KB | dww |
| #5 | hidden_panes.jpg | 21.59 KB | pancho |
| #4 | 271765_panels_hidden_pane_colors.4.patch | 1.14 KB | dww |
| #3 | panels-hidden-pane-colors.orig_.png | 15.38 KB | dww |
Comments
Comment #1
merlinofchaos commentedHidden panes should already be greyed out. This is a bug that they are not.
Comment #2
dwwOh, I guess there's a tiny bit of difference already. For comparison, here's what it looks like now... So, I propose to make the differences more obviously visible.
Comment #3
dwwWhoops, I missed. ;) Try this.
Comment #4
dwwHere's a patch that accomplishes this so folks can try it on their own sites. Note, this happens to fix a minor bug in the .css where the grabber:hover style wasn't applied on hidden panes due to a missing leading dot, so it was using the same grabber:hover style as regular panes. Now that I tried it with the intended style, I kind of like the dark blue-ish grey, for this -- maybe we could keep that part. ;)
Comment #5
panchoHere's a screenshot with all four states a pane can be in. The orange star is hardly visible for unsaved-hidden.
Also note that a different hover color is only set for saved panes. We might want to change that.
Comment #6
merlinofchaos commentedI like the colors in the screenshot. dww: Is the dark bluish-grey something different?
Comment #7
dwwYes, the dark-bluish grey is this:
which isn't visible without the leading .
Here's a screenshot while hovering over a hidden pane with this color in use ("orig") vs. the pure grey hover color from my patch ("dww").
Comment #8
merlinofchaos commentedWhat about the 'changed' pane color?
Comment #9
dww@merlin: see the screenie from #5.
Comment #10
sdboyer commentedI'm all thumbs-up on this now. Committed.
Comment #11
sdboyer commentedComment #12
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.