The documentation at http://api.drupal.org/api/function/drupal_urlencode/5 lists the code sample for drupal_urlencode and shows a call to rawurlencode. The current downloadable codebase actually uses urlencode instead.

I am not sure if the issue is the documentation being out of sync, or the issue is actually in the codebase. Not using the rawurlencode function has resulted in broken paths containing spaces on my site, so perhaps this should be a bug report against drupal core?

Comments

gollyg’s picture

gollyg commented

Have also posted at http://drupal.org/node/271780

gpk’s picture

gpk commented

The problem you have outlined was fixed on May 26 - http://drupal.org/node/191116. So the fix is not in 5.7. It *will* be in any 5.8 release (unless reverted between now and then :-P ), or just use 5.x-dev if you want it now.

gpk’s picture

gpk commented
Status: Active » Fixed

So the API docs are actually correct (in that they match 5.x-dev, which is what they are supposed to do).

To see the 5.7 version you have to browse CVS (or look at your own downloaded copy!):
http://cvs.drupal.org/viewvc.py/drupal/drupal/includes/common.inc?view=l...
http://cvs.drupal.org/viewvc.py/drupal/drupal/includes/common.inc?annota...

gollyg’s picture

gollyg commented

No worries. Thanks for the response.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.