This module works fine, but it has one limitation I can't live with: I can only use it by navigating to http://site.com/search/google
Instead, I want to embed the search in another page so I can put other text around it. I also want to then use the page as my home page. I can get the latter by creating a page and promoting it to the front page.
How would I get the functionality of search/google embedded in another page?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | add_pre_post.patch | 2.23 KB | bdornbush |
| #9 | add_pre_suf.patch | 2.21 KB | bdornbush |
| #5 | add_pre_post.patch | 2.01 KB | bdornbush |
Comments
Comment #1
mfbYou should be able to place the Google CSE block on any page.
If you're asking about also embedding the results on some other page, that should be doable although would require some form altering.
Comment #2
bdornbush commentedYes, I can place the Google CSE block on a page, including the home page, but it shows as a block and is hard for me to place the text I want around it.
If I understood your second point, I will have to modify the module to alter the form. I don't know of a way to embed a form like search/google on the front page. That is what I am really looking for. Is there a way?
Comment #3
mfbYou can modify the display of the form thru your theme -- any drupal form can be themed.
You can also alter any form via hook_form_alter() -- no hacking necessary.
Comment #4
mfbOne thing I'm thinking as far as feature requests is that the Google CSE results page could be rendered as a block. That would allow the results to be placed anywhere. There would also need to be some means to set the form action (telling the form what path to GET).
Comment #5
bdornbush commentedI found that the requirements I had could be met if I used search/google as my front page. Then I needed a way to put some text around the form, and so that I could provide my client with an easy way to manage the text, I added "prefix" and "postfix" fields to the Admin Settings. The fields are null unless something is entered, so there is no change to the original look unless someone enters something in these fields.
I submit my changes as a patch in case you want to include this in the module, or in case someone else wants to take this approach. Since this is the first time I have created a patch, I hope it works OK. I use Windows for my test system, where I did the editing using Eclipse, and then used Cygwin to create and test the patch file.
I also use the block on other pages on the site so that users can access it from wherever they are on the site. The block is not affected by my patch, so I have the original block and an enhanced page.
Comment #6
mfbThanks for the patch. It is probably helpful for non-developers.
It should be suffix rather than postfix. And you don't want to call t() on a variable; t() should only be for strings in the code. Also btw you never want to call t(NULL), bad things will happen. Rather than t() it should be something like this:
filter_xss_admin(variable_get('google_cse_results_prefix', ''));And, you need to create a CVS diff, not a regular diff, see http://drupal.org/patch
On the command-line this would be
cvs diff -up > my.patchalthough you can also use Eclipse. Make sure you get a fresh CVS checkout so you are patching against the current code.Comment #7
mfbMarked an older issue as a duplicate: http://drupal.org/node/195948 since this issue has a patch.
Comment #8
mfbMarked an older issue as a duplicate: http://drupal.org/node/195948 since this issue has a patch.
Comment #9
bdornbush commentedHere is the revised patch against the latest v5 code. I used diff because I haven't yet figured out how to make cvs diff work from my Windows + Eclipse + Cygwin environment, but I hope that the patch will prove useful. I believe it can be applied when created this way, too.
I appreciate your comments on how to improve the code. I am just learning how to be a developer.
Comment #10
bdornbush commentedI found a very helpful web site, moodle.org, that had a section on how to use Eclipse, including how to generate a CVS patch at http://docs.moodle.org/en/Development:Setting_up_Eclipse#Creating_a_patch.
So here is the CVS Patch.
Comment #11
mfbComment #12
mfbCommitted to 5.x-1.x; refactored and committed to 6.x-1.x.
Thanks bdornbush!
Comment #13
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.