The default location form is missing line breaks between labels and fields on attached node submission/edit forms.

CommentFileSizeAuthor
#2 location_6.patch5.54 KBankur

Comments

ankur’s picture

div class="container-inline"
is being used to help make sure the labels end up on the same line, but this doesn't seem to work in any of the drupal core themes. In the contributed themes that come with the CivicSpace distribution, the label for the field on the next line actually trails the form item on the line of the previous form item.

I'm open to rewrites of the html layout for the form generation function (location_form(), defined in location.inc).

-Ankur

ankur’s picture

Status: Active » Fixed
StatusFileSize
new5.54 KB

A fix has been committed to DRUPAL-4-6. A seperate patch will be rolled for HEAD at a later time since the same patch won't apply as cleanly given the overhaul of the forms API.

The problem was not missing line-breaks, it was the hope that a <div class="container-inline"> would override an enclosed <br/>. The hope was to have the label for each address field appear on the same line as the form element.

For example, we wanted the word "Street" to show up on the same line as the textfield element. However, this is not possible because the form generating function in Drupal (at least 4.6) generate a <br/> after the label but before the actual form element. For this reason, I just got rid of the <div class="container-inline">'s altogether.

-Ankur

Anonymous’s picture

Status: Fixed » Closed (fixed)