Posted by Steve McKenzie on June 19, 2008 at 4:48am
| Project: | Better Select |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Attached is a patch that improves the CSS.
1) replaced max-height with height so it works in IE6
2) added position:relative to fix the good ol' fun IE6 rendering issue
3) removed the unneeded line-height
4) changed the active state highlight to look like the autocomplete list with the nice drupal blue :)
| Attachment | Size |
|---|---|
| betterselect_css_improvements.patch | 720 bytes |
Comments
#1
status change..
#2
I like the colour change, however it results in the following when there are fewer than 10 items.
#3
ahh i see.
well, maybe we should just use JS to set the height since min- max-height wont work in IE?
#4
I suppose it's more often that a user will have IE than a user having JS disabled (even though I frequently have JS disabled, which means a huge glop of checkboxes for me on every node ;)).
Is it possible to do CSS for every other sane browser, and JS as a crutch for IE? Or is it better to just do it one way (JS) that works for (most) everyone?
I leave it to your discretion. :D
#5
im fine with that.
i'll do the js for IE6 only.
#6
subscribing
#7
Can I go ahead and do some of these CSS changes? How were you going to do IE specific fixes?
What problem does the position: relative solve?
Thanks!