Attached is a patch that improves the CSS.

1) replaced max-height with height so it works in IE6

2) added position:relative to fix the good ol' fun IE6 rendering issue

3) removed the unneeded line-height

4) changed the active state highlight to look like the autocomplete list with the nice drupal blue :)

CommentFileSizeAuthor
#2 Picture 1.png10.33 KBwebchick
betterselect_css_improvements.patch720 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

status change..

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Needs work
StatusFileSize
new Picture 1.png10.33 KB

I like the colour change, however it results in the following when there are fewer than 10 items.

Anonymous’s picture

Anonymous (not verified) commented

ahh i see.

well, maybe we should just use JS to set the height since min- max-height wont work in IE?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I suppose it's more often that a user will have IE than a user having JS disabled (even though I frequently have JS disabled, which means a huge glop of checkboxes for me on every node ;)).

Is it possible to do CSS for every other sane browser, and JS as a crutch for IE? Or is it better to just do it one way (JS) that works for (most) everyone?

I leave it to your discretion. :D

Anonymous’s picture

Anonymous (not verified) commented

im fine with that.

i'll do the js for IE6 only.

arhak’s picture

arhak commented

subscribing

Mark Theunissen’s picture

Mark Theunissen commented

Can I go ahead and do some of these CSS changes? How were you going to do IE specific fixes?

What problem does the position: relative solve?

Thanks!

john franklin’s picture

john franklin commented
Status: Needs work » Fixed

I think we can close this one out. No one uses IE6 anymore. The other changes are either applied or just colors.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.