Maximum picture size help text in profile no longer needed

Bug in above patch (missing paren) fixed.

The maximum width and height dimensions still apply when there is no image library installed (see user_validate_picture()). Maybe we could detect if an image library is present and inform the user their picture will automatically be resized to dimension x and y, otherwise the text is displayed as it presently is.

I didn't even know we could run without an image library installed. Is that a valid scenario, or more of a left-over from the Drupal 4.5 era? If possible, I'd prefer having one way of doing things, rather than having a new and old way of doing things.

I am all for a image-toolkit-only system. But I am a bit concerned that that will rule out a lot of people who have no access to the server/php set up.

So, would it be worth it, for sake of usability and ease-of use to demand a toolkit for thumbs, and leave those who have no server softwar efor hendling images without avatars?

-1 on this.

For one thing, it still makes sense to inform people what the maximum avatar size is. Don't underestimate how many avatars are custom made for a particular site.

Secondly, it is important to know the maximum size for animated avatars... if they go over the maximum size, they are resized and come out as static images. Without this info you would need trial and error to figure it out.

The big problem with displaying the dimensions and maximum size is that if people have an image that exceeds those limits, they will not bother to upload the image because they think they will have to open their image editing software to do that. Those instructions serve as an image upload deterrent, not a help at all.

Here's a compromise patch to address Steven's objection. I don't know the best way to detect if an image library is installed. Someone else will have to write that or at least save me time and give me a hint on how to do it.

You can use image_get_toolkit() to check if an image library is installed. Here's some sample code taken from user.module.

Once the profile help text is based on the existence of an image library, this patch would be good to go.

You can use image_get_toolkit() to check if an image library is installed. Here's some sample code taken from user.module.

Once the profile help text is based on the existence of an image library, this patch would be good to go.

Thanks for the hand, Mathias. Here's a new patch.

+1 for this patch and the additional help text it provides.

The patch applies and works.

But I find the text: Your image will be automatically resized to fit the maximum dimension of 100x100 and maximum file size of 200 k
strange. how can something be resized under the maximum file size of 200 k ?

On second thought: I (personally) dislike giving this kind of information. These are exactly the texts that scare people away, or at least make them not even read a text.

But I will not object against this patch on that basis, since I can change it, using locales. I will change it to "If your image is too big, it will be resized". For me, that is more then enought information. And for Joe Average it s too.

I agree with Ber, there is no need to scare or bore end users with this kind of info.

Here is what I want you to do: go for a image toolkit only approach -- that is what we introduced toolkits for. If I'm not mistaken, there are several toolkits available in contrib so people should be able to find a working toolkit.

This means, you'll have to simplify/test user_validate_picture() and the surrounding code. While testing, I'd modify image_get_toolkit() to return NULL to 'simulate' the absense of a toolkit.

Can you investigate that?

Dries, who are you addressing here?

nysus: mainly you but also the other developers who want to see this fixed.

Yeah, I'll take a look into it when I get a chance.

Patch per Dries request.

patching file user.module
Hunk #1 FAILED at 241.
Hunk #2 FAILED at 1161.
2 out of 2 hunks FAILED -- saving rejects to file user.module.rej

This feature request is it still valid ?

here's a current version of this.

Works like a charm, but has a different approach then #20. Was that intentionally (there have of course been some changes since 2005)?

I think the easier solution would be to not allow the site admin to enable user pictures if there is no image toolkit. I'd like to incorporate this issue into #305802: Improve default user picture interface since this issue seems like it's lost it's steam.

Dave Reid, no need to take such a simple help fix off topic. don't let the perfect be the enemy of the good. if i've got a single user site and i want my account to have a picture but don't have gd, it's much simpler for me to just scale one image by hand than to recompile php.

Whoops. Sorry drewish! I'll continue in my issue and not bother you again here. :)

The last submitted patch failed testing.

No longer fails locally, so resetting.

While we're here, can we split that really long array into multiple lines?

Reroll per #30.
And I unassigned Steve, because he hasn't been in this thread since 2005.

The last submitted patch failed testing.