The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.It seems there's tiny bug here.
We have two versions of VB: "VB 1.4" and "VB dev".
flag_views_bookmark_update_prepare() upgrades VB 1.4 to the latest state by running the update functions. The code is:
for ($version = $vb_schema; $version <= 5102; $version++) {
$update_function = 'views_bookmark_update_'. $version;
if (function_exists($update_function)) {
It looks for 'views_bookmark_update_NNN' function whereas these functions were renamed to flag_views_bookmark_update_NNN'.
I'm attaching a patch --but it wasn't tested.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | vb14upgrd6.diff | 1.7 KB | mooffie |
| vb14upgrd.diff | 903 bytes | mooffie |
Comments
Comment #1
mooffie commentedCommited. (I figured it's best to commit this asap so we get feedback from users. That's what beta is for.)
Comment #2
mooffie commentedWe need to port this to D6. Here's the patch I propose. Two upgrade functions use Views 1 API, so I masked their names. We could remove them altogether.
Comment #3
quicksketchGood call on the function name corrections. Initially I thought I'd use the original update functions, but realized a lot of users will delete Views Bookmark before starting with Flag, so it'd be better to include copies of the updates. I think we should just remove those Views updates entirely. The user will have to do some amount of manual importing of each View anyway from Drupal 5 to 6.
Comment #4
mooffie commentedOK, I've just done that, for the D6 branch.
(Sort of: I left the function skeletons and just emptied they bodies, but left a note. I didn't want some future explorer to wonder "but I think something is missing here.")
Comment #5
quicksketchRock. Thanks!
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.