Attached patch removes camel case: setUp to set_up on line 32, testPathAuto to test_pathauto on line 52.
Patch also removes several cases of DOS line endings.

CommentFileSizeAuthor
#6 SP20080620-pathauto-dos2unix.patch5.84 KBsamirnassar
#2 SP-20080619-camelcase-dos2unix.patch5.84 KBsamirnassar

Comments

samirnassar’s picture

samirnassar commented
Status: Active » Needs review
samirnassar’s picture

samirnassar commented
StatusFileSize
new SP-20080619-camelcase-dos2unix.patch5.84 KB
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work

I believe that camelcase is appropriate for test files, so that's a bug with coder module if anything.

The dos line ending is certainly a problem, though.

samirnassar’s picture

samirnassar commented
Title: pathauto.test containst camelcase and DOS line endings » pathauto.test DOS line endings

That's good to know. I'll reroll the patch against the latest pathauto to address only the DOS line endings.

I'll see if I can bug the coder maintainer about camelcase.

samirnassar’s picture

samirnassar commented

Filed update with coder: http://drupal.org/node/149807

samirnassar’s picture

samirnassar commented
Status: Needs work » Needs review
StatusFileSize
new SP20080620-pathauto-dos2unix.patch5.84 KB

This patch only addresses line endings

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

And committed. Thanks steamedpenguin!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.