Greetings!

Right now, if I submit a vote, the karma score button becomes opaque for a fraction of a second, then shows the updated score.

I was hoping for two things, which should be easy for folks who know JS and css I think:

(1) increase the fraction of a second to a time of my choice
(2) allow an overlay image, like an animated gif, to show over teh karma button.

I think this should take a few lines of code in extra_voting_forms.js and extra_voting_forms.css, but am not familiar with how to do the first in JS nor the second in CSS (my image shows up behind the button:( ).

KarmaSendForm is the function that needs some change to accommodate (1), and

in extra_voting_forms.css, i'm talking about the class:

html.js .karma_sending {
...
}

Anyone willing to help a brother out?

Thanks a billion.

CommentFileSizeAuthor
#3 extravotingforms_timeout-sendingclass_272784_3.patch5.23 KBcedricfontaine

Comments

mercmobily’s picture

mercmobily commented

Hi,

I know zip about Javascript. This is probably a task for Sicjoy.

Sicjoy, what do you think?

Merc.

cedricfontaine’s picture

cedricfontaine commented
Assigned: Unassigned » cedricfontaine
cedricfontaine’s picture

cedricfontaine commented
StatusFileSize
new extravotingforms_timeout-sendingclass_272784_3.patch5.23 KB

With this patch you can change timeout in administration.

You can also choose to hide karma_form and karma_form_promoted when submitting a vote. It will offer you a way to add an animated gif in karma_sending.

cedricfontaine’s picture

cedricfontaine commented
Status: Active » Needs review
cedricfontaine’s picture

cedricfontaine commented
Status: Needs review » Patch (to be ported)

Committed in Drupal-5 branch.

mercmobily’s picture

mercmobily commented

Hi,

Cedric, have you commited this already?
Can you please also commit it to the DRUPAL-6-1 branch?

Bye,

Merc.

cedricfontaine’s picture

cedricfontaine commented

How do I do that ? Should I do it to all my commit ?

mercmobily’s picture

mercmobily commented

Hi,

Do to that, Cedric, you need to checkout the DRUPAL-6-1 branch (somewhere inside a Drupal 6 install) and basically apply the same changes that you apply to DRUPAL-5.
A way to do that without double-editing is:

* Apply the changes to DRUPAL-5

* Run "cvs diff" which will tell you how you changed your local copy

* Apply the diff to your DRUPAL-6-1 branch. Since the code is so similar between the 2, it will definitey apply. However, maybe apply the patch with the --dry-run option just to check before you actually change files...

Alternatively, for mall patches, just change the code twice :-D

Bye!

Merc.

mercmobily’s picture

mercmobily commented
Status: Patch (to be ported) » Fixed

Hi,

OK, ported to the DRUPAL-6--1 branch as well. All done.

Merc.

mercmobily’s picture

mercmobily commented
Status: Fixed » Closed (fixed)