Allowing '#' as a link with the l() function

mattconnolly - June 20, 2008 - 10:31
Project:Drupal
Version:7.x-dev
Component:base system
Category:feature request
Priority:normal
Assigned:mattconnolly
Status:patch (code needs work)
Description

The l() function does not accept '#' as a link URL address. Here is a patch that allows this.

AttachmentSize
allow-hash-url.patch1.04 KB
Testbed results
allow-hash-url.patchfailedFailed: Failed to apply patch. Detailed results

#1

samirnassar - June 20, 2008 - 16:48
Version:6.2» 7.x-dev
Status:patch (code needs review)» patch (code needs work)

You should re-roll the patch against HEAD, that is Drupal 7. If you need help making this happen, chime in.

#2

Robin Monks - August 31, 2008 - 23:43
Status:patch (code needs work)» patch (code needs review)

Free re-roll compliments of patch bingo.

Robin

AttachmentSize
allow-hash-url-7.x[1].diff1.19 KB
Testbed results
allow-hash-url-7.x[1].diffre-testing

#3

System Message - November 16, 2008 - 21:45
Status:patch (code needs review)» patch (code needs work)

The last submitted patch failed testing.

#4

lilou - November 17, 2008 - 13:11
Status:patch (code needs work)» patch (code needs review)

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

#5

catch - November 22, 2008 - 01:55
Status:patch (code needs review)» patch (code needs work)

Seems like a reasonable idea, the last patch has tabs in though.

 
 

Drupal is a registered trademark of Dries Buytaert.