Comments

emackn’s picture

Any updates on the port?

univate’s picture

Version: 5.x-5.x-dev » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new22.11 KB

What is the deal with this module? cvs is showing the files have been removed...

Anyway I needed this module ported to 6.x so attached is a patch against 1.x-dev which should work

univate’s picture

StatusFileSize
new22.85 KB

Seems I was a little hasty to post this, attach is a new patch to fix some bugs and you also need the patch I have posted here - #340642: hook_nodewords() in 6.x version ? for this to work.

univate’s picture

StatusFileSize
new25.01 KB

further bug fixes...

Anonymous’s picture

The patch in #4 applies and appears to work.

Flying Drupalist’s picture

Is the dev testable? Thanks for this module.

univate’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Fixed

This patch has been applied and a new 6.x-1.x-dev branch has been created for this module.

It works, I'm using it on a live site myself, but it depends on the current 6.x-1.x version of Meta tags being patched with this issue #340642: hook_nodewords() in 6.x version ? (it wont work otherwise)

Please test if you can and report any issues.

Once this depending issue has been applied to the meta tags module I will look to create a stable release of this module for D6.

Flying Drupalist’s picture

So far so good, thanks.

Flying Drupalist’s picture

Hmm one problem. When I save the admin settings page, the page empties out. When I click edit on the rule, I see nothing filled in. But the rule itself actually works when I check the meta tags.

owen barton’s picture

Assigned: » Unassigned
Status: Fixed » Needs review
StatusFileSize
new33.18 KB

Here is a patch based on #4 with several bug fixes and Drupal 6-ifications, such as proper usage of menu arguments (with object loading) and also use of drupal_write_record for saving. I have tested new rules, editing and deletion, as well as actual display of keywords and description and it all seems to work.

If needed I can go back and work out a patch based on 6.x-dev, but considering this was just applied it is probably easier to just apply this to 5.x-dev and recommit.

univate’s picture

Assigned: Unassigned » univate
Status: Needs review » Fixed

Those extra changes look good to me, I have committed this patch into 6.x-dev

owen barton’s picture

Lovely - thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

JStarcher’s picture

How's the stability of this module? Perhaps we are ready for a stable release?

univate’s picture

Yeah I think we are ready - no-ones reported any major issues and nodewords has a stable 6.x release.

So 6.x-1.0 is released.