Closed (fixed)
Project:
Nodewords by Path
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Anonymous (not verified)
Created:
20 Jun 2008 at 17:47 UTC
Updated:
3 Dec 2018 at 14:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
emackn commentedAny updates on the port?
Comment #2
univate commentedWhat is the deal with this module? cvs is showing the files have been removed...
Anyway I needed this module ported to 6.x so attached is a patch against 1.x-dev which should work
Comment #3
univate commentedSeems I was a little hasty to post this, attach is a new patch to fix some bugs and you also need the patch I have posted here - #340642: hook_nodewords() in 6.x version ? for this to work.
Comment #4
univate commentedfurther bug fixes...
Comment #5
Anonymous (not verified) commentedThe patch in #4 applies and appears to work.
Comment #6
Flying Drupalist commentedIs the dev testable? Thanks for this module.
Comment #7
univate commentedThis patch has been applied and a new 6.x-1.x-dev branch has been created for this module.
It works, I'm using it on a live site myself, but it depends on the current 6.x-1.x version of Meta tags being patched with this issue #340642: hook_nodewords() in 6.x version ? (it wont work otherwise)
Please test if you can and report any issues.
Once this depending issue has been applied to the meta tags module I will look to create a stable release of this module for D6.
Comment #8
Flying Drupalist commentedSo far so good, thanks.
Comment #9
Flying Drupalist commentedHmm one problem. When I save the admin settings page, the page empties out. When I click edit on the rule, I see nothing filled in. But the rule itself actually works when I check the meta tags.
Comment #10
owen barton commentedHere is a patch based on #4 with several bug fixes and Drupal 6-ifications, such as proper usage of menu arguments (with object loading) and also use of drupal_write_record for saving. I have tested new rules, editing and deletion, as well as actual display of keywords and description and it all seems to work.
If needed I can go back and work out a patch based on 6.x-dev, but considering this was just applied it is probably easier to just apply this to 5.x-dev and recommit.
Comment #11
univate commentedThose extra changes look good to me, I have committed this patch into 6.x-dev
Comment #12
owen barton commentedLovely - thanks!
Comment #14
JStarcher commentedHow's the stability of this module? Perhaps we are ready for a stable release?
Comment #15
univate commentedYeah I think we are ready - no-ones reported any major issues and nodewords has a stable 6.x release.
So 6.x-1.0 is released.