Providing that http://drupal.org/node/263325 goes in, I think it makes a lot more sense for jQuery Update to provide this setting, and jQuery UI to just respect it.

CommentFileSizeAuthor
#9 jquery_ui-remove-compression-273161-9.patch3.18 KBwebchick
#2 jquery_ui-remove-compression-273161-2.patch2.95 KBwebchick
#1 jquery_ui-remove-compression-273161-1.patch2.92 KBwebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new jquery_ui-remove-compression-273161-1.patch2.92 KB

Here's a patch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new jquery_ui-remove-compression-273161-2.patch2.95 KB

And here's a better one. :P

mfer’s picture

mfer commented

Shouldn't jquery_ui_add still provide the ability to override the compression type? This patch doesn't just use the compression setting from jquery_update, it remove the ability to override the compression type.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I was talking it over with Nate/quicksketch, and he felt this was a pretty superfluous setting, and I'm inclined to agree. Furthermore, it seems like it would introduce support requests if a user sets "packed" and suddenly certain modules are calling in jQuery UI files as 'none', overriding the admin's wishes.

Can you think of a good reason for this to be here that can't be done by changing the compression setting at admin/settings/jquery_update for your whole site while debugging?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Postponed » Needs work

This needs a re-roll. And some more discussion. :)

mfer’s picture

mfer commented

I can't think of a reason or time i would use it other than in development. Then, I might want one of the files to be an uncompressed version when troubleshooting. It really isn't that big of a deal. Maybe a nice thing to have during development but I doubt I would personally use it.

I'm fine either way :).

Is there anyone actually using this feature?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I doubt it. I'm pretty sure it was one of those feature-creep-as-you-write, "Huh. Well I guess we could pass that in as a parameter too!" kind of deals. :)

mfer’s picture

mfer commented

Wow, fast response.

If there are no complaints than removing it would simplify the code. Who isn't for that? :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new jquery_ui-remove-compression-273161-9.patch3.18 KB

Ok, I committed the following patch. I think we're making this change early enough that hopefully no one will notice... esp. considering the official release doesn't work at all atm. ;P

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.