Hi,

I'm currently using your module and it's great.
The only issue I had with it was that the search form does not include the hidden encoding field.

When searching in Hebrew, the are no results because the default encoding of the google search is not UTF-8 (as my drupal site).

I added a few lines to your module, so the encoding field will be included in the search form and also in the module admin settings form.

please review the code, and try to add it to the next version because I believe it will be valuable for many around the world.

Gonen.

CommentFileSizeAuthor
google_cse.module.patch1.23 KBgonen.radai

Comments

mfb’s picture

mfb
they or he
commented

Thank you for the patch, I didn't realize that Google defaults to latin1 as opposed to utf8. I will work on this soon.

What about other parameters for internationalization? gl, hl, lr, etc.

gonen.radai’s picture

gonen.radai commented

You're welcome...

the hl parameter will be useful as well I think.
I didn't know what are the others, so i start looking it up and found this:
http://yoast.com/dl/wp-content/uploads/2007/07/google-url-parameters.pdf

I think lr,gl and all other localization paramters can go as "advanced settings" or maybe even localization tab,
so they won't confuse the simple users and won't overload the settings form.

Glad I could help,

Gonen

mfb’s picture

mfb
they or he
commented
Status: Needs review » Patch (to be ported)

I found a help page indicating that custom search business edition defaults to latin1, but in my testing it looks like CSE default to utf8.

In any case, I added this setting and some other internationalization-related settings. Do you have the ability to test the CVS version of the module?

mfb’s picture

mfb
they or he
commented
Status: Patch (to be ported) » Fixed

This is fixed in CVS but still needs testing (it's available in the dev snapshots).

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.