A patch to fit with http://drupal.org/node/271694

CommentFileSizeAuthor
271694_drupalorg_better_help_no_search.patch2.2 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work

I was going to mention that if/when this is implemented it needs a path specific visibility rule to only show it on 

search
search/*

However, the block visibility rules seem to follow menu access rules - i.e. if the users don't have permission to visit "search" at the menu level then they don't see block content limited to that page as well.

So, instead we can do the negative - set it to appear on every page except:

admin
project
node
user
cvs
tracker
taxonomy
admin/*
project/*
node/*
user/*
cvs/*
tracker/*
taxonomy/*
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review

Not sure why this was "needs work".

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Fixed

I've committed the patch and updated the code on d.o.

mfb’s picture

mfb
they or he
commented

It would be nice to use a CSE so the Drupal Association can share ad revenue from the traffic it's directing to Google.

Bojhan’s picture

Bojhan commented

It would be wise, to do what mfb is saying. It is really not a lot of work and "can" bring in quite some money for the association.

JohnForsythe’s picture

JohnForsythe commented

Looks good.

The only thing I wonder about is if CSE starts bringing in a significant amount of money, what incentive is there to fix normal search? ;)

mfb’s picture

mfb
they or he
commented

Not that I'm a big advocate of ads but I guess if revenue were a concern one could put big pricey "Drupal.org search sponsored by" ads on search/* pages.

catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Needs work

This seems to have broken the contributor links block.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Can you be more specific than "broken"?

When I look at the blocks on the side of the page I don't see contributor links any more - I assume that's what you mean? If the contributor links was in drupalorg.module it was in a local version that wasn't committed to CVS (that's just a wild guess at a possible cause). I'm not sure how this change could have impacted that.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Fixed

Sorry, terrible bug report.

First I had no contributor links block.

I visited my account and it had been disabled, enabled it again, and still no contributor links. I'm only blaming this issue because that's the latest change, might just be bad timing.

Let's mark this back to fixed and I'll open a new issue.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

It appears that I missed aggregator as a path where it should be blocked. That's now added.

catch’s picture

catch
he/him
Primary language English
commented

Could you add comment* to the exclusions list? It shows up on edit/reply at the moment.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Yes, done.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.