Better help with search is disabled (patch for drupalorg module)
greggles - June 22, 2008 - 14:11
| Project: | Drupal.org customizations |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | greggles |
| Status: | closed |
Jump to:
Description
A patch to fit with http://drupal.org/node/271694
| Attachment | Size |
|---|---|
| 271694_drupalorg_better_help_no_search.patch | 2.2 KB |
#1
I was going to mention that if/when this is implemented it needs a path specific visibility rule to only show it on
searchsearch/*
However, the block visibility rules seem to follow menu access rules - i.e. if the users don't have permission to visit "search" at the menu level then they don't see block content limited to that page as well.
So, instead we can do the negative - set it to appear on every page except:
adminproject
node
user
cvs
tracker
taxonomy
admin/*
project/*
node/*
user/*
cvs/*
tracker/*
taxonomy/*
#2
Not sure why this was "needs work".
#3
I've committed the patch and updated the code on d.o.
#4
It would be nice to use a CSE so the Drupal Association can share ad revenue from the traffic it's directing to Google.
#5
It would be wise, to do what mfb is saying. It is really not a lot of work and "can" bring in quite some money for the association.
#6
Looks good.
The only thing I wonder about is if CSE starts bringing in a significant amount of money, what incentive is there to fix normal search? ;)
#7
Not that I'm a big advocate of ads but I guess if revenue were a concern one could put big pricey "Drupal.org search sponsored by" ads on search/* pages.
#8
This seems to have broken the contributor links block.
#9
Can you be more specific than "broken"?
When I look at the blocks on the side of the page I don't see contributor links any more - I assume that's what you mean? If the contributor links was in drupalorg.module it was in a local version that wasn't committed to CVS (that's just a wild guess at a possible cause). I'm not sure how this change could have impacted that.
#10
Sorry, terrible bug report.
First I had no contributor links block.
I visited my account and it had been disabled, enabled it again, and still no contributor links. I'm only blaming this issue because that's the latest change, might just be bad timing.
Let's mark this back to fixed and I'll open a new issue.
#11
It appears that I missed
aggregatoras a path where it should be blocked. That's now added.#12
Could you add comment* to the exclusions list? It shows up on edit/reply at the moment.
#13
Yes, done.
#14
Automatically closed -- issue fixed for two weeks with no activity.