This patch is the first iteration through eliminating normal warnings. Please change status to "code needs work" after applying the patch. I will provide follow up patches.

Eliminating all (critical, normal and minor) coder warnings is important since I (and other developers) cannot start working on patches for a project for which coder gives warnings.

Additionally character encoding of files are not UTF-8. That's the reason Eclipse is trying to patch those Turkish strings.

CommentFileSizeAuthor
#4 turkish_banks_code_beautification_continued.patch12.38 KBmustafau
#2 turkish_banks_code_beautification.patch21.02 KBmustafau
turkish_banks_normal_warnings.patch11.66 KBmustafau

Comments

bakyildiz’s picture

bakyildiz commented
Assigned: Unassigned » bakyildiz
Status: Needs review » Needs work

your patch is applied to development snapshot

mustafau’s picture

mustafau commented
Status: Needs work » Needs review
StatusFileSize
new turkish_banks_code_beautification.patch21.02 KB

Another iteration on code beautification.

bakyildiz’s picture

bakyildiz commented

I have commited the uc_turkish_banks.module file with version 1.6. I also review the code and i think that all buautification has been done. Thanks a lot.

mustafau’s picture

mustafau commented
StatusFileSize
new turkish_banks_code_beautification_continued.patch12.38 KB

I believe there is always room for improvement. What do you think about attached patch?

Once this is in I will work on encapsulating strings with t() function and better XML generation.

bakyildiz’s picture

bakyildiz commented

Oh I see. Of course, there is too many things to do with this module. But according to the coder there was no more warnings.
I think one more job is to convert the Turkish wordings to English and create a translation file.

bakyildiz’s picture

bakyildiz commented
Status: Needs review » Closed (fixed)