Posted by mustafau on June 22, 2008 at 4:39pm
| Project: | Ubercart Turkish Banks Gateway |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | bakyildiz |
| Status: | closed (fixed) |
Issue Summary
This patch is the first iteration through eliminating normal warnings. Please change status to "code needs work" after applying the patch. I will provide follow up patches.
Eliminating all (critical, normal and minor) coder warnings is important since I (and other developers) cannot start working on patches for a project for which coder gives warnings.
Additionally character encoding of files are not UTF-8. That's the reason Eclipse is trying to patch those Turkish strings.
| Attachment | Size |
|---|---|
| turkish_banks_normal_warnings.patch | 11.66 KB |
Comments
#1
your patch is applied to development snapshot
#2
Another iteration on code beautification.
#3
I have commited the uc_turkish_banks.module file with version 1.6. I also review the code and i think that all buautification has been done. Thanks a lot.
#4
I believe there is always room for improvement. What do you think about attached patch?
Once this is in I will work on encapsulating strings with t() function and better XML generation.
#5
Oh I see. Of course, there is too many things to do with this module. But according to the coder there was no more warnings.
I think one more job is to convert the Turkish wordings to English and create a translation file.
#6