Closed (fixed)
Project:
Drupal.org Testing
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
22 Jun 2008 at 20:44 UTC
Updated:
4 Apr 2009 at 01:10 UTC
Jump to comment: Most recent file
Since most of these modules aren't ported to D6 yet, I have no idea if the profile actually /works/, but this at least gets rid of the fatal errors. :)
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | drupalorg_testing.patch | 4.47 KB | hunmonk |
| #14 | drupalorg_testing.patch | 7.53 KB | hunmonk |
| #13 | drupalorg_testing.patch | 8.01 KB | hunmonk |
| #12 | drupalorg_testing.patch | 22.43 KB | hunmonk |
| #7 | drupalorg_testing.patch | 205.29 KB | hunmonk |
Comments
Comment #1
webchickMarking needs work because I'm quite sure that many other issues will come up as we go along, but this should be safe to commit as a starting point.
Comment #2
dwwThis would actually be quite handy for working on the d.o upgrade sprints. We should consider using Install Profile API while we're at it.
Comment #3
dwwp.s. Although, both myself and aclight have had success running the install profile in D5, then upgrading that site to D6 including both core and contrib -- helps test the DB upgrades, etc. So, this isn't a show-stopper... but it would still be handy.
Comment #4
gábor hojtsyNot required for the drupal.org upgrade.
Comment #5
hunmonk commentedi'm working on this now. after spending too many hours trying to get drupal_execute() to do my bidding, i've finally given up and decide to start the conversion to the install profile API.
Comment #6
webchickOh, +1000 for install profile API conversion. That project just simply sucked when we first started this project back in 2007. :) It's much much better now. :D
Comment #7
hunmonk commentedcommitted this first effort, which is basically working.
couple of things to resolve:
Comment #8
hunmonk commentedalso, we should probably convert the taxonomy saving stuff to either be embedded in the node_save()'s if we can, or at the very least leverage install profile api's taxo functions.
Comment #9
hunmonk commentedoops, forgot to mention that this profile will need the latest project_issue code, and this patch to install profile api: http://drupal.org/node/408040
Comment #10
hunmonk commentedComment #11
dwwFYI: Last night I committed #408040: functions for creating nodes so this works if you just use the latest Install Profile API code from DRUPAL-6--2 branch or 6.x-2.x-dev.
I also committed a fix to the profile to use install_goto() instead of drupal_goto(). After that, light testing seems to work about as well as the D5 version does. ;) Thanks, hunmonk!
Comment #12
hunmonk commentedcommitted the following, which removes the clunky batch method for the shiny and pretty batch API.
not completely working yet, but the batching stuff is right.
Comment #13
hunmonk commenteddrupal_execute() strikes again... :(
turns out we can't use that function at all if we're using batch API, so it's forced to die.
this will also need to be corrected in project issue generate module.
attached is the conversion of taxonomy stuff to the install profile API -- already committed.
Comment #14
hunmonk commentedattached fixes some taxonomy bugs introduced in the last round, and finally rids the profile of all remaining drupal_execute()'s -- yay!!!
be sure to get latest project issue before testing, because of #408870: convert generation of comments to use project_issue followup api
already committed.
Comment #15
hunmonk commentedattached has been committed, and fixes a few remaining bugs with issue status, taxonomy, and update messages.
everything seems to be working well now, except for one thing: the batch api messages aren't getting printed on the finished screen. i suspect that there's no call to get the messages in install.php, but not sure. we may need our own custom step before the final screen to print them if we care.
Comment #16
hunmonk commentedlet's call this done and file anything else as a new issue.
batch messages bug is now at #409010: batch messages not displayed on final screen