forum_uninstall nastiness [#273761]

forum_uninstall has this line in it:

db_query("DELETE FROM {node} WHERE type = 'forum'");

1. It's not using the node API - so {comments}, CCK fields, {node_revisions}, {node_comment_statistics} and anything else will be left stale in the DB.
2. AFAIK, book.module doesn't delete book nodes etc. forum topics can and are used in places other than forums.
3. No warning is given that it's going to simply delete all that data

IMO, just remove it.

Comment	File	Size	Author
#3	forum_uninstall-d5.patch	650 bytes	catch
	forum_uninstall_craziness.patch	680 bytes	catch

Comments

Comment #1

nedjo

he/him/his

English

commented 24 June 2008 at 15:26

It's an open question what should happen with the orphan data associated with these nodes, but yes, simply deleting the node table rows is wrong and in many cases will leave the install in a worse state than leaving them there.

Looks like we should delete this line as suggested and wait for a real solution.