Apotrophe in Site Name causes bad Subject line in Email.

tjharman - June 23, 2008 - 11:47
Project:Comment Mail
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Description

Hello!

I have a site called Tim's Diary. Whenever Comment Mail sends me an email notifying me of a new comment, the subject reads as follows:

[Tim& #039;s Diary] New Comment posted on (I had to insert a space between the & and the # otherwise Drupal kept rendering it correctly.)

Is it possible to make it so that these characters are parsed and mailed correctly in the subject field?

Regards,
Tim

#1

maartenvg - October 24, 2008 - 07:14
Version:5.x-1.0-beta» HEAD
Status:active» needs review

Attached patch fixes this.

There were 2 problems with that line:
- uses '@' placeholders instead of '!' placeholders, this will perform check_plain on the replacements, which is not wanted in a e-mail subject.
- @site content was wrapped in a additional check_plain(), which is overkill because the '@' already does that and unnecessary because of what I said above.

AttachmentSize
273784_commentmail_subject_has_htmlentities.patch 933 bytes

#2

maartenvg - October 24, 2008 - 17:47
Version:HEAD» 5.x-1.x-dev
Status:needs review» fixed

Fixed this in CVS and will find its way into the next version of Comment mail.

Thanks for reporting this!

#3

Anonymous (not verified) - November 7, 2008 - 17:51
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.