1. There's a small mistake in a t() usage, where a /div/ tag was actually inserted in the string.
2. There's a string which says "1=worst, 10=best", but the voting actually begins at 0, not at 1.

Patch is attached.

CommentFileSizeAuthor
#1 nodevote.module_0.patch1.27 KBbaudolino
nodevote.module.patch1.27 KBbaudolino

Comments

baudolino’s picture

baudolino commented
Status: Fixed » Needs review
StatusFileSize
new nodevote.module_0.patch1.27 KB

Sorry. Missed an apostrophe. This should be the correct version.

kbahey’s picture

kbahey commented

Fixed.

Thanks for the patch.

Please note that 0 is not a valid vote. Votes go from 1 to 10 only. Therefore, I did not commit this part.

kbahey’s picture

kbahey commented
Assigned: Unassigned » kbahey
Status: Needs review » Fixed
baudolino’s picture

baudolino commented

"Please note that 0 is not a valid vote. Votes go from 1 to 10 only. Therefore, I did not commit this part."

Right, but the drop-down selection box for the votes displays 0 as an option.

kbahey’s picture

kbahey commented

0 should not be a valid score.

Now nodevote lists "Select" and then 1 to 10.

If "Select" is defaulted, then the vote is not registered, and an error message is displayed.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
kindafun’s picture

kindafun commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)