Patches for D6 specific changes, coder.module reports no critical warnings.

TODO:

  • when creating a smackdown, it currently fails to concatenate the title names of the 2 nodes chosen and ends up with a blank title.
  • break out the theme into a template file.
CommentFileSizeAuthor
#2 d6smackdown_1.patch12.19 KBsirkitree
#1 d6smackdown.patch9.61 KBBrightLoudNoise
d6smackdownmodule.PATCH6.83 KBBrightLoudNoise
d6smackdowninstall.PATCH2.13 KBBrightLoudNoise
d6smackdowninfo.PATCH651 bytesBrightLoudNoise

Comments

BrightLoudNoise’s picture

BrightLoudNoise commented
StatusFileSize
new d6smackdown.patch9.61 KB

same patches but rolled as 1 cvs diff of the module directory.

sirkitree’s picture

sirkitree commented
StatusFileSize
new d6smackdown_1.patch12.19 KB

Thanks. Applied this locally and started some debugging. Autocomplete isn't working yet. Someone removed Drupal.autocompleteAutoAttach! We'll have to figure out something else, I'll get some advice tomorrow.

BrightLoudNoise’s picture

BrightLoudNoise commented

Based on http://drupal.org/files/issues/drupal_reattachable_behaviors_0.patch

Drupal.autocompleteAutoAttach = function () became Drupal.behaviors.autocomplete = function (context)

Let's touch base tomorrow.

BrightLoudNoise’s picture

BrightLoudNoise commented

@sirkitree: I'm having trouble applying your patch against what's currently in CVS

patching file smackdown.info
Hunk #1 succeeded at 1 with fuzz 1.
patching file smackdown.install
patching file smackdown.module
Hunk #5 succeeded at 178 (offset -3 lines).
Hunk #7 succeeded at 223 (offset -3 lines).
Hunk #8 succeeded at 236 with fuzz 2.
Hunk #9 FAILED at 245.
Hunk #10 succeeded at 268 (offset -15 lines).
Hunk #12 succeeded at 611 (offset -15 lines).
Hunk #14 succeeded at 783 (offset -15 lines).
1 out of 14 hunks FAILED -- saving rejects to file smackdown.module.rej
sirkitree’s picture

sirkitree commented

Are you sure you have what's in CVS, DRUPAL-5--2 ?

Checkout the module with cvs using the following command:
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib co -d smackdown -r DRUPAL-5--2 contributions/modules/smackdown

The patch should apply cleanly to this. I just tried it and it worked perfectly.

Fayna’s picture

Fayna commented

Worked fine for me. I was able to define my Smackdown content type and create a Smackdown. I typed in the names of two contestant nodes that existed, though, and it wouldn't let me save:

That id does not exist, make sure you choose from the list.
That id does not exist, make sure you choose from the list.

But I guess that has to do with the autocomplete thing?

sirkitree’s picture

sirkitree commented

Yeup, I was hacking around a little last night trying to get the autocompletes working, and I think they're going to need completely rethought. I believe we can create autocompletes now strictly using FAPI since the AHAH functionality is not incorporated. I started taking apart nodereference.module in order to see how it's being done there and would like to use that as the design for these. However there are quite a lot of FAPI changes in D6 that I need to learn in order to accomplish this. Anyone with some better clues, please help out!

BrightLoudNoise’s picture

BrightLoudNoise commented

The patch does indeed apply cleanly, I was pulling the wrong version from CVS.

sirkitree’s picture

sirkitree commented
Assigned: BrightLoudNoise » Unassigned
Status: Needs work » Fixed

D6 version is now being worked on. A new branch has been committed and a dev release created. Please see the following: http://drupal.org/node/345518

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.