D6 Port

Patches for D6 specific changes, coder.module reports no critical warnings.

TODO:

when creating a smackdown, it currently fails to concatenate the title names of the 2 nodes chosen and ends up with a blank title.
break out the theme into a template file.

Comment	File	Size	Author
#2	d6smackdown_1.patch	12.19 KB	sirkitree
#1	d6smackdown.patch	9.61 KB	BrightLoudNoise
	d6smackdownmodule.PATCH	6.83 KB	BrightLoudNoise
	d6smackdowninstall.PATCH	2.13 KB	BrightLoudNoise
	d6smackdowninfo.PATCH	651 bytes	BrightLoudNoise

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

BrightLoudNoise CreditAttribution: BrightLoudNoise commented 24 June 2008 at 04:28

File	Size
d6smackdown.patch	9.61 KB

same patches but rolled as 1 cvs diff of the module directory.

Comment #2

sirkitree CreditAttribution: sirkitree commented 25 June 2008 at 02:53

File	Size
d6smackdown_1.patch	12.19 KB

Thanks. Applied this locally and started some debugging. Autocomplete isn't working yet. Someone removed Drupal.autocompleteAutoAttach! We'll have to figure out something else, I'll get some advice tomorrow.

Comment #3

BrightLoudNoise CreditAttribution: BrightLoudNoise commented 25 June 2008 at 04:13

Based on http://drupal.org/files/issues/drupal_reattachable_behaviors_0.patch

Drupal.autocompleteAutoAttach = function () became Drupal.behaviors.autocomplete = function (context)

Let's touch base tomorrow.

Comment #4

BrightLoudNoise CreditAttribution: BrightLoudNoise commented 25 June 2008 at 14:34

@sirkitree: I'm having trouble applying your patch against what's currently in CVS

patching file smackdown.info
Hunk #1 succeeded at 1 with fuzz 1.
patching file smackdown.install
patching file smackdown.module
Hunk #5 succeeded at 178 (offset -3 lines).
Hunk #7 succeeded at 223 (offset -3 lines).
Hunk #8 succeeded at 236 with fuzz 2.
Hunk #9 FAILED at 245.
Hunk #10 succeeded at 268 (offset -15 lines).
Hunk #12 succeeded at 611 (offset -15 lines).
Hunk #14 succeeded at 783 (offset -15 lines).
1 out of 14 hunks FAILED -- saving rejects to file smackdown.module.rej

Comment #5

sirkitree CreditAttribution: sirkitree commented 25 June 2008 at 15:01

Are you sure you have what's in CVS, DRUPAL-5--2 ?

Checkout the module with cvs using the following command:
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib co -d smackdown -r DRUPAL-5--2 contributions/modules/smackdown

The patch should apply cleanly to this. I just tried it and it worked perfectly.

Comment #6

Fayna CreditAttribution: Fayna commented 26 June 2008 at 04:06

Worked fine for me. I was able to define my Smackdown content type and create a Smackdown. I typed in the names of two contestant nodes that existed, though, and it wouldn't let me save:

That id does not exist, make sure you choose from the list.
That id does not exist, make sure you choose from the list.

But I guess that has to do with the autocomplete thing?

Comment #7

sirkitree CreditAttribution: sirkitree commented 26 June 2008 at 15:25

Yeup, I was hacking around a little last night trying to get the autocompletes working, and I think they're going to need completely rethought. I believe we can create autocompletes now strictly using FAPI since the AHAH functionality is not incorporated. I started taking apart nodereference.module in order to see how it's being done there and would like to use that as the design for these. However there are quite a lot of FAPI changes in D6 that I need to learn in order to accomplish this. Anyone with some better clues, please help out!