Module generates unnecessary HTML output (notably: box) when page header field is empty.

Attached patch simplifies HTML output in this case.

CommentFileSizeAuthor
#4 feedback.module_1.patch1 KBEric Scouten
feedback_empty_pageheader.patch673 bytesEric Scouten

Comments

Eric Scouten’s picture

Eric Scouten commented
Title: Module generates bad input if page header is empty » Module generates unnecessary output if page header is empty

Just making the title clearer.

kbahey’s picture

kbahey commented

Eric

Can you please use the command: cvs diff -u so that patch is in Unidiff format?

Eric Scouten’s picture

Eric Scouten commented

Sure. I probably won't be able to do it until tomorrow. (Note: Same comment applies to all the other patches I submitted yesterday. They were all done with the wrong format. Sorry... first time doing it on Mac OS.)

Eric Scouten’s picture

Eric Scouten commented
StatusFileSize
new feedback.module_1.patch1 KB
kbahey’s picture

kbahey commented
Status: Needs review » Fixed

Commited this to the repository and 4.6 version

Thanks Eric.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)