Please add file size infomation to image_get_info()

+1 for this feature. But we should be carefull with it, though. This function is called an awful lot. Cvbe, have you got experience with benchmarking? I am interested to see if this has an impact on speed and performance.

If so, we could consider a lower level (inside the function) "caching": just see if the file exists in the file table, if so return those functions.

But let's not keep that from including this filesize.

I have not done a benchmark, but I would guess stat-ing a file is much less expensive then opening it up, parsing the file structure, and figuring out the dimensions.

image_get_info() already calls is_file(), which does a stat() and caches the result. If my understanding is correct, that means the call to filesize() will hit the cache and thus have the minimum possible performance impact.

Here's an updated patch correcting a spelling error.

please do not get my comment as a "I do not lke it" :) I was merely wondering if this was going to have an impact on operformance.
But from what I see now, the PHP cache will save the day. But... does that cache live on forever? Or only for one PHP run?

I'm sorry if my comments seemed caustic. I was merely being frank.

The clearstatcache() doc page seems to imply that the PHP cache only lives for one page. But adding filesize() to image_get_info() would not change performance, as a stat() is already run for is_file(). Now, would removing is_file() help performance? I can't say.

Committed to HEAD.