one page - all selected menus
drupalok - June 24, 2008 - 15:54
| Project: | MenuTree |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | ebrand |
| Status: | closed |
Description
hi there - nice module!
but it would be even better, if one could choose the menus to be displayed on one page together (like a complete sitemap)
i did not find any module to combine menus to one either...
greetings
sebastian
#1
New features will only go into the 6.x version.
I am not entirely clear what the use case here is. I'm not against it, I suppose, but I'm curious why it would be needed.
#2
sitemap/all works great in dev version, thanks.
#3
Yeah, I had a client ask for that at some point. It needs to be ported forward to the D6 version, then both need a stable release to include it. Anyone want to do the D6 port of that feature? :-)
#4
+1 for this functionality!
Then it will make it a great sitemap.
@msn
What do you mean with 'sitemap/all' ?
#5
JoepH:
Oehh...., What I remember.
The sitemap/all issue is outdated. In an older version you could not create a complete sitemap, only the dev version (at that time) owned this feature. It this moment the dev version is an official release.
With compliments to the module developer(s).
Martin
#6
Here's a patch for D6
#7
I have an update to the previous patch
#8
- It looks like the patch has tabs in it instead of two-spaces for indentation. All Drupal code should use two-space indentation.
- The indentation is off in menutree_display_all().
- The default weight for menus in the "all" page is set to none, so no menus will show until the admin page has been submitted. However, the defaults on the admin page are to show, in increasing order. That creates a disconnect if you're just looking at the admin page but haven't submitted it. We should probably normalize those to none in both cases for consistency.
- The if-else in menutree_display() should have the else on its own line:
<?php
if ($blah) {
}
else {
}
?>
- I'm unclear why you're switching the constants from a bitwise check to an equality check.
#9
Here is the updated patch
#10
Committed #9. Awesome!
#11
Automatically closed -- issue fixed for 2 weeks with no activity.