bulk generate assigns a variable and never uses it - stop that

greggles - June 24, 2008 - 17:15
Project:Pathauto
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

http://drupal.org/node/183625#comment-893444

#1

Freso - June 24, 2008 - 17:44
Category:task» bug report
Status:active» patch (code needs review)

I've gone through and eradicated "$alias = " in all instances if ($alias = ...). (Also, this being cruft, I'd consider it a bug.)

AttachmentSize
274382_stop_variable_assigning-1.patch3.91 KB

#2

Freso - June 28, 2008 - 15:49
Status:patch (code needs review)» fixed

Greg wanted me to commit this... so I did.

#3

Anonymous (not verified) - July 12, 2008 - 15:52
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#4

Freso - July 22, 2008 - 17:23
Status:closed» patch (to be ported)

As we may have to release a 6.x-1.2 for Drupal 6.3 compatibility, this should probably be backported. Might as well be backported to 5.x-2.x too, just in case, while we're at it.

#5

Freso - August 5, 2008 - 17:34
Status:patch (to be ported)» fixed

Committed to 6.x-1.x and 5.x-2.x.

#6

Anonymous (not verified) - August 19, 2008 - 17:44
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.