For me, concenated images to the teaser and the body is very limiting.
I want the image to appear somewhere else, wrapped in some more advanced HTML. image.module as it is now, does not allow this, because it has the concenation hardcoded.
This patch introduces two thelme functions theme_image_teaser and theme_image_body.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | image_theme_0.diff | 1.62 KB | Bèr Kessels |
| image_theme.diff | 991 bytes | Bèr Kessels |
Comments
Comment #1
ezheidtmann commented+1. Sounds like a good idea to me, and the code looks sane.
Comment #2
basicmagic.net commentedhi ber-
what does this do exactly...?
how would you use it...
any more info on this would be greatly appreciated...
Comment #3
ezheidtmann commentedThese are theme functions you can override in your theme. See the docs: http://drupal.org/node/11774
Comment #4
Robrecht Jacques commented+1 on the idea.
I'm wondering though if this patch will work. What is $request set to in
? Obviously not to
$request = ($_GET['size']) ? $_GET['size'] : 'preview';as it was before.Maybe the theming functions need to be:
The last one just out of consistency.
Comment #5
Bèr Kessels commentedoops; the preview was wrong. My theme did not mind, so I never saw this bug. this patch fixes that.
Comment #6
Bèr Kessels commentedStill applies. Please review! please?
Comment #7
Robrecht Jacques commentedTested this patch (of comment #5): applies, works as described, coding style ok.
These theming functions won't hurt anyone.
I propose to commit it to CVS and 4-6.
Comment #8
Bèr Kessels commentedbump. walkah, what is holding this patch? If you have no time, I can commit it too, after you say so.
Comment #9
zach harkey commented+1 I don't know how people are getting by without this.
Comment #10
Bèr Kessels commentedAgain: boing
please, give an update on this. Ii is very critical for me to know if this patch may make it in or not!! I am willing to commit it myself, but I need feedback! walkah? robrecht? anyone, should I commit it?
Comment #11
Robrecht Jacques commentedThis is ready to be committed. Except for:
That hunk will fail.
BTW: in my "sandbox-image" I've added this too, because I think it is very usefull and probably needed.
Comment #12
Bèr Kessels commentedYup.
My misake. I have anew patch that removed that line. I will commit later. this weekend or Monday.
Comment #13
Bèr Kessels commentedCommitted to HEAD
Comment #14
(not verified) commentedComment #15
(not verified) commentedComment #16
(not verified) commented