Needs review
Project:
FriendFeed
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
25 Jun 2008 at 12:48 UTC
Updated:
11 Jul 2008 at 18:46 UTC
Jump to comment: Most recent file
Comments
Comment #1
robloachIs your server behind a proxy? Can you use drupal_http_request? I also somewhat expected bugs in the Drupal 5 version. If you find any fixes, please post how you overcame them.
Comment #2
micahw156Rob,
I can duplicate this. I can retrieve my feed using the block, but not on
user/1/friendfeed.I traced the problem to function
friendfeed_user_view, but couldn't figure out how to fix it.The problem is that
$useris not set correctly, so things like$user->nameand$user->friendfeed_usernamecannot be retrieved. It did work if I addedglobal $user;within the function, but only to retrieve my own feed while logged in as me, of course.Not sure if the calling parameters are messed up, or if a user_load is needed. My knowledge this area aren't strong enough.
Thanks for back-porting this to 5.x, by the way! Glad I don't have to wait to use it!
Micah
Comment #3
robloachAhhh, it's because in the Drupal 6 menu system, the user object is passed to the function. In Drupal 5, however, just the user ID is passed. I just committed a work around. Again, sorry for not testing, haha.
Comment #4
steve hanson commentedThis still appears to be broken. With todays release I'm still getting
Invalid argument supplied for foreach() in /var/www/drupalexp/modules/user/user.module on line 53.
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT * FROM users u WHERE in /var/www/drupalexp/includes/database.mysqli.inc on line 151.
But the block works.
Comment #5
micahw156Rob,
This issue is giving me a great crash course in both D5 and D6 APIs, and the differences between them. I'm enjoying it! So, now I know the difference between user_load for D5 and D6. Attached patch changes arguments for user_load to array in both places that it's used. Rolled against the latest (July 2) 5.x-1.x-dev.
Micah
Edit: Sorry. First patch was bad. Only needed change in one place, not both. Uploading friendfeed.274763-6.patch to fix.Edit again: Arrgh! Replacing patch file again. Try friendfeed.274763-7.patch
Comment #6
robloachPatch committed.... Thanks, Micah. Hope it helps.
Comment #7
jonathanbloom commentedSorry, I had company and forgot to respond. Glad to see a patch is in the works and my site isn't behind a proxy.
Comment #8
robloachIs this happening on 6.x too? I can't get the feed on my personal site..... http://robloach.net/about
Comment #9
jonathanbloom commentedI'm only using Drupal 5 right now.