I noticed problems in the uc_pma module where I was trying to do remove_line_item() and then getTax()

The problem is that the current remove_line_item() function does enough to prevent a line item from showing up during rendering, but does not do enough to remove the item from tax calculation. Here is the adjustment I propose.

Change in uc_payment.js:

function remove_line_item(key) {
  li_titles[key] = '';
  render_line_items();
}

to...

function remove_line_item(key) {
  delete li_titles[key];
  delete li_values[key];
  delete li_weight[key];
  delete li_summed[key];
  render_line_items();
}

Comments

rszrama’s picture

rszrama commented
Assigned: Unassigned » rszrama
Status: Needs review » Fixed

Tested this on the Livetest. Didn't bother duplicating the bug, but this doesn't break existing functionality. It's a go! Thanks for the fix. : )

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

letsnurture’s picture

letsnurture commented

Hye, cYu

First of all, thanks to you.

I had been facing the same problem in ubbercart.I had created the workflow-ng to set up a tax for a specific zone(A) and when I select that state(A) at that time the line item didn't show me the tax to be applied to that state(A).

I had googled for 4-5 days and then I looked the above snippets and I used the way you shown me and it has fixed the probllem.

Can you plz tell me what did it make to happen? It was really a weird thing that I've ever seen!!!!!!!

It had really made me to scratch my hair!!!!!

Thanks a lot

Web Farmer

http://letsnurture.co.cc/