This is a fix for the oft-mentioned 'Access Denied' issue. The fix is very simple - the menu system now requires that all items have access control. The main menu item for login destination did not have any access control. I've also added the hook_perm, to allow non-user-1 users to be granted the ability to administer this module.

Be sure to disable this before upgrading - or, if you've upgraded while it's enabled, disable and re-enable it. The menu system caches things.

I've tested this out and everything appears to be working as before. If you're looking for a maintainer for this module, I'd be happy to do it.

CommentFileSizeAuthor
#9 login_destination_6.4.patch460 bytesjeremdow
#8 login_destination_access-274869-8.patch894 bytesmrtoner
full module - login_destination_d62.tar.gz8.83 KBchiddicks
logindestination.module patch - logindestination62.patch937 byteschiddicks

Comments

chiddicks’s picture

chiddicks commented

Sorry, I failed to notice the patch made by drewish. Our patches only differ in that I add a specific permission for this admining this module.

gagarine’s picture

gagarine commented
Status: Needs review » Reviewed & tested by the community

work for me

matt b’s picture

matt b
Primary language English
commented

I have Destination URL Settings set to static URL and Redirection Settings set to a list of paths. I am not redirected on login when the condition is met.

drewish’s picture

drewish commented

i think adding a separate permission is a good idea, marking #255093: Need to have 'access callback' to work with Drupal 6. as a duplicate.

ardas’s picture

ardas commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot guys for your work!
I have implemented your patch with minor changes and improvements.
Please download 6.x-2.0 release

Many thanks again especially for your patience.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Patch for Drupal 6.2 » Access admin settings - Patch for Drupal > 6.2
Version: master » 6.x-2.1
Status: Closed (fixed) » Reviewed & tested by the community

Still not fixed!

  $items['admin/user/login_destination'] = array(
    'title' => 'Login destination',
    'description' => 'Configure where user will go after login.',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('login_destination_admin_settings'),
+    'access arguments' => array('administer site configuration'),
  );

for example

mrtoner’s picture

mrtoner commented
StatusFileSize
new login_destination_access-274869-8.patch894 bytes

Yes, it appears the patch committed for 6.x-2.0 didn't make it into 6.x-2.1. I've taken ARDAS's changes (based on those by chiddicks) and created this patch for 6.x-2.1.

jeremdow’s picture

jeremdow commented
StatusFileSize
new login_destination_6.4.patch460 bytes

Oops - posted this patch on the duplicate issue - http://drupal.org/node/296840 - but why not just do as andypost suggested?

One less permission for admins to manage.

mikojak’s picture

mikojak commented

worked for me, thanks!

marcp’s picture

marcp commented
Assigned: chiddicks » Unassigned
Status: Reviewed & tested by the community » Closed (duplicate)

Duplicate of #292006: Can't see admin page