As the title said at the moment simpletest doesn't include the tests located in the includes dir. After adding that part I found out the tests were sorted by using module_list(). They are now sorted by group.

CommentFileSizeAuthor
#7 simpletest_includes_dir.patch896 bytesR.Muilwijk
#5 simpletest_includes_dir.patch644 bytesboombatower
simpletest_includes_dir.patch859 bytesR.Muilwijk

Comments

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical
Status: Active » Reviewed & tested by the community

XML-RPC doesn't appear without this, nor the registry/common.inc tests. I thought it was fixed already, but clearly not.

boombatower’s picture

boombatower commented

Do we want all the tests for each include to be in the includes directory? I know that is how it works right now, but that means doubling the size (or close to it) eventually.

What about a tests directory since we have to break the standard used for modules anyway?

R.Muilwijk’s picture

R.Muilwijk commented

@boombatower, I'm fine with that too. Just as long as I'm able to test them :D

boombatower’s picture

boombatower commented
Status: Reviewed & tested by the community » Needs work

The ksort($groups) seems to work incorreclty as it places "PHP" before "Path" group.

I don't think we need the extra sorting.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new simpletest_includes_dir.patch644 bytes

Rerolled patch to remove ksort and read from includes/tests

Tests that need to be moved are:

  • common.test
  • registry.test
  • xmlrpc.test

I'm not including those in patch since I would prefer they are moved to ensure no unnecessary changes.

R.Muilwijk’s picture

R.Muilwijk commented

Hmmz, I'll have a look at it. However I think we do need a sorting. With no sorting Bootstrap, Common, XMLRPC ends at the end of the page though everything was always sorted by group name before.

R.Muilwijk’s picture

R.Muilwijk commented
StatusFileSize
new simpletest_includes_dir.patch896 bytes

New patch with sorting fixed

boombatower’s picture

boombatower commented

Once this makes it in #245961: XMLRPC value_calculate_type throws exception needs to be checked.

boombatower’s picture

boombatower commented
Status: Needs review » Reviewed & tested by the community

Very simple patch...check the PHP, path and they seem fine.

Ran a test and that worked.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.