This is a great starter theme!

I would suggest however that you use ids rather classes for the major layout DIVs: eg, the sidebars, content, header and footer -- those elements that appear only once, basically. This is consistent with most other drupal themes, and makes overriding rules easier because there's more selector specificity available.

CommentFileSizeAuthor
#1 foundation_class-to-id_275185-1.patch6.45 KBadd1sun

Comments

add1sun’s picture

add1sun commented
Version: 5.x-1.0 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new foundation_class-to-id_275185-1.patch6.45 KB

Good call. I hadn't even noticed that and it is much more a best practice to use ids. Patch attached for HEAD.

add1sun’s picture

add1sun commented
Status: Needs review » Fixed

Added to HEAD (6 dev tarball).

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Project: Foundation »
Version: 6.x-1.x-dev »
Issue summary: View changes

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 2925308)