Upgrade from 5.x-1.10 to 5.x-1.11 causes redirect errors (which breaks Google crawling)

Bodo Maass - June 26, 2008 - 11:20
Project:Localizer
Version:5.x-1.11
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs review
Description

I just checked my google sitemaps and noticed that google reported all non-english URLs as unreachable due to redirect errors. This had already happend with localizer on drupal4.7, but it went away after upgrading to drupal5 and localizer 5.x-1.
However, after the recent upgrade to 5.x-1.11 I'm seeing those redirect errors again. I bit of searching revealed that for the new version a few new calls to drupal_goto were added to the function localizer_change_uilocale in localizer.module.
I understand that localizer is setting the ui locale and then redirects to the current url to reload the new locale. However, Google doesn't follow redirects to self and reports this as an error.
For my configuration the offending drupal_goto is on line 919. After removing that line, everything works fine again. Removing that line doesn't seem to have any negative effect, and in any case, my site was working fine with localizer 5.x-1.10, so if that extra goto was fixing a bug, I wasn't affected by it in the first place. On the other hand, I really want google to index my site.

AttachmentSize
localizer.module.patch561 bytes
 
 

Drupal is a registered trademark of Dries Buytaert.