Posted by fletchgqc on June 26, 2008 at 12:40pm
4 followers
| Project: | Nodequeue |
| Version: | 6.x-2.0-rc1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
- Giving a role "manipulate all queues" permission causes no difference in the behaviour of nodequeue.
- Giving a role "administer nodequeue" permission doesn't change anything either (not sure exactly what this permission is meant to do).
- Giving a role "manipulate queues" permission does work as advertised.
Comments
#1
on line 1554 of nodequeue.module, $role_args is used in the
db_placeholders()function, but $role_args is not defined. anymore (looks like it was last seen in 1.45 or so).I believe it should be just $roles instead of $role_args?
#2
Here is a patch that changes $role_args to $roles.
#3
Works for me.
It also seems to resolve #167465: SQL warnings when user has manipulate queue permission. Were either of you observing SQL errors as described in that issue?
#4
Wasn't experiencing issue #167465, sorry can't comment. Sorry I'm not even in a position to test that your patch works right now but it sounds from other comments like it does!
#5
Committed, thanks! Catch this in the next release candidate.
#6
Automatically closed -- issue fixed for two weeks with no activity.