I am currently focusing this feature request at the uc_discounts module located at http://www.ubercart.org/contrib/143 that was submitted by pcambra in comment #124. I will try to keep this feature request targeted towards the latest uc_discounts package until it is committed into the drupal.org repository at which point we can target a specific version.
Currently, the uc_discounts module modifies a products page when a discount is applied by adding a "discount" price. This price is not being updated as different attributes are selected. The "display_price" is also broken and no longer updated.
Comments
Comment #1
jantoine commentedI finished the integration of these two modules. A small modification was required for the uc_discounts module as well, and since it has no repository to make a patch against, here is what needs to be done. In the uc_discounts_nodeapi function, the text "(discounted from $price)" must be moved outside the "
" container and placed in it's own container with the class "full_price" (i.e.
). Once this is finished and the patch applied, everything should be in working order. You can also use this same information for theming product pages.
Comment #2
cyu commentedI took a quick glance at the patch and think I follow what you are doing here and it looks ok to me.
As we discussed earlier, I don't plan on applying this patch unless uc_discounts moves from being a zip file in a comment on an ubercart project page to having a maintained release on drupal.org . Have you been in any contact with the original creator of the module? If they aren't interested in maintaining it any longer, perhaps you'd like to?
Comment #3
jantoine commentedI have been contemplating becoming the maintainer of the Discounts module and checking it into drupal.org. The current maintainer stated early on that he had no interests in further maintenance of the module once his clients bailed on him. My concern was that it is a pretty hefty module and might be a bit much for my first maintained module. I think I'll go ahead and get it into drupal.org and try to get some co-maintainers. I'll let you know when I get it into drupal.org.
Comment #4
johnphethean commentedPlease do it Antoine!!
There's loads of folk willing to pay for this module to become a reality. It's a necessity in the project I'm working on at the moment to have basic role-based discount, & I personally think they should make it part of Ubercart core.
I've never been involved with a maintained module either but I'll help test it if you need. I'm sure pcambra and 'frost' will help with maintaining too.
Good luck... :)
Comment #5
jantoine commentedI have updated this patch to work with uc_aac 5.x-1.4.
Cheers,
Jon Antoine
www.antoinesolutions.com
"Open Source Development Tutorials & Documentation"
Comment #6
joachim commentedHi Antoine.
Psynaptic (drupal.org/user/93429/view) and I want to get uc_discounts onto drupal.org. We both of us already have CVS access and maintain several modules.
We've not had any response yet on the contrib page -- if the original author isn't around or interested any more, I guess that means we can go ahead and create the project here, probably next week :)
Want to join us as co-maintainer?
Comment #7
cyu commentedAlso asked for in 6.x #348507: uc discounts integration for 6.x
Comment #8
jantoine commentedClosing this issue out. No new features will be added to the 5.x-1.x branch. Ubercart 2.0 offers discount integration via the price handler functionality.
Cheers,
Antoine