Closed (fixed)
Project:
Flag
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Jun 2008 at 06:03 UTC
Updated:
15 Jul 2008 at 00:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
mooffie commentedHere's the patch.
Comment #2
mooffie commentedMarked #275028: Fatal error: Cannot access empty property (flag.views.inc) a duplicate of this. (That user's problem is because of point #3.)
Comment #3
archetwist commentedI've tested this patch and I can say it resolves my issue (#275028). However, there is another problem: when editing a view relationships and fields show up twice.
I am not sure if I should open a new issue on this but it would be useful if in the relationship configuration you could choose multiple flags and if there was a field that could print all of them. It would save users a lot of time. Currently you have to configure individual relationships and fields for each of the flags.
Comment #4
mooffie commented(I don't understand this sentence. I'll assume your following paragraph, which I do understand, is an explanation of the above. So I'll ignore the above.)
If I understand correctly, what you're asking for is operation akin to that of the Drupal 5 version of this module. In the D5 version you have to click only 10 times (not really, but sort of) to include 10 'Ops' fields in the view. ('ops' is our nickname for the flag links.)
On the other hand, if it's 10 'Ops' fields that you want, then you can simply use the 'Node' row style and you won't even have to click 10 checkboxes, because all 'Ops' are in the node links.
Nate, what are your thoughts on this?
Comment #5
mooffie commented(See you next week. As for the new discussion: I'd suggest, before we discuss it further, that we commit my patch because the current V2 support doesn't really work. Perhaps it worked in previous Views beta, but seemingly not in the latest(s) release(s).)
Comment #6
gagarine commentedtracking
I don't know if i need open a new bug but:
In the filter for view2 they have:
Flags: Flagged
Filter to ensure a node has or has not been flagged.
Flags: Flagged time
Display the time the node was flagged by a user.
But what don't have another filter :
Flags: user id
Display the node flagged by this user
Comment #7
Fayna commentedThe patch worked for me too. I can view "My Bookmarks" now. :-)
Comment #8
mooffie commentedarchetwist, in comment #3, writes:
I've opened a new issue to address your concerns.
Comment #9
mooffie commentedThis isn't realy a bug, but I opened a new issue: #276899: Missing "UID" argument
Comment #10
quicksketchThis looks great to me. Thanks for figuring out a way to find that flag option everywhere moofie! I ended up creating the $view->flags array after getting fed up trying to navigate the view object. Thanks for fixing that ->nid/cid reference too, again, I simply couldn't find the appropriate place to pull the field aliases from.
Comment #11
mooffie commentedGreat, so we can close this.
(archetwist and gagarine: I opened seperate issues for the points you raised.)
Fortunately, V2 has a nice trait: handlers can reach out to other handlers. (A nice example is the way the 'depth' taxonomy argument works: it modifies the previous argument.)
Comment #12
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.