Starbuck noted a problem with farbtastic and it looks like there is one.

Here is the code that's causing the problem...

/**
 * Array of jQuery files to replace if jQuery is loaded.
 */
function jquery_update_get_replacements() {
  return array(
    'module' => array(
      'misc/farbtastic/farbtastic.js' => 'farbtastic.js',
    ),
  );
}

The only problem is farbtastic.js isn't in the root of the jquery_update module anymore. It's now in the replace folder. So, the array in the function above needs to say farbtastic.js is at 'replace/farbtastic.js'.

I can't roll a patch because I don't have a setup to do so at the moment and wanted to document this.

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Normal » Critical

Oh, goll darnit!

Fixing...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Postponed (maintainer needs more info)

Hm. Really? I can't reproduce this.

View-source on http://localhost/6x/admin/build/themes/settings/garland gives me:

 <script type="text/javascript" src="/6x/sites/all/modules/contrib/jquery_update/replace/jquery.packed.js?k"></script>
<script type="text/javascript" src="/6x/misc/drupal.js?k"></script>
<script type="text/javascript" src="/6x/modules/color/color.js?k"></script>
<script type="text/javascript" src="/6x/sites/all/modules/contrib/jquery_update/replace/farbtastic.js?k"></script>
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Btw, that's true that the array has only "farbtastic.js" but below where it's replacing it, it says:

/**
 * The path to the jQuery files that need to be replaced.
 */
define('JQUERY_UPDATE_REPLACE_PATH', drupal_get_path('module', 'jquery_update') . '/replace');

...

            $replace = JQUERY_UPDATE_REPLACE_PATH . '/' . $replace;
mfer’s picture

mfer commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

Doh, I'm the one who isn't paying attention. My setup is on a machine without the GD library so it's not going to work at all. Time to go back to my standard testbed.

Nothing to fix. Move along.