Heya,
good module, works nicely :)

Only spotted one little blemish: the html-validator yields a warning for the '</a>' in the document.write statement (more information). That's easily fixed by inserting a backslash before the forward slash. Attached is a respective patch file (patch against today's 6.x-1.x-dev)

CommentFileSizeAuthor
validator-warning.patch702 bytesbforchhammer

Comments

eabrand’s picture

eabrand commented
Status: Needs review » Reviewed & tested by the community

The patch works, but I don't see the reason for inserting it into the module. The source code shows up as with or without the "\"

bforchhammer’s picture

bforchhammer commented

I guess this patch is more about good style/coding practice than malfunction; I like my sites to pass validation if possible. (That said; this patch is almost a year old - I haven't checked if the issue still exists)

eabrand’s picture

eabrand commented
Status: Reviewed & tested by the community » Needs work

How would I test the issue you were having? My source code looks fine.

eabrand’s picture

eabrand commented
Assigned: Unassigned » eabrand
bforchhammer’s picture

bforchhammer commented

I had a CCK field with the invisimal formatter on it which inserts something like the following into the source code:

<script type='text/javascript'><!--
    document.write('<a href="&amp;#109;[.......]'+'">'+'email@example.com'+'</a>');
//-->
</script>

I think my htmltidy firefox plugin told me that the forward slash / in +'</a>'); should be escaped. Our page is running in XHTML 1.0 Strict.

We're still using 6.x-dev from 2008-Jun-14 with my patch; if you don't mind waiting 1-2 days I can update to the most recent version, check if the issue still exists and get back to you...

bforchhammer’s picture

bforchhammer commented

Sorry that it took me a few days longer than I said...
I'm failing to reproduce the error message myself so please feel free to just close and bury this issue. ;-)

Crell’s picture

Crell commented
Status: Needs work » Fixed

I am OK with closing issues. :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.