Tests needed: Database layer

Since http://drupal.org/node/225450 comes with tests, we should postpone this pending the outcome of that issue (although let's hope there's only one possible outcome). Might as well test code that's not disappearing imminently.

I'm stealing this issue to submit the tests that were written for the new DB layer. This covers all tests written to date. We certainly can add more, but let's start with these. :-)

I had a very, very quick read through and nothing bad jumped out, and ran all tests (they pass). Are these what used to be with dbtest.module? In that case, they've probably been reviewed a few times before anyway, but leaving this open in case someone's got time to take a closer look.

The patch looks good functionally, but some clean-up is required:
- Indentation is off in a few places.
- Some comments contain development messages (like "// Barry, what's going on here? :-) --LG")
- Empty setUp() declarations are not necessary.

Your code style is inconsitant

+      $before_age = db_query("SELECT age FROM {test} WHERE name='Ringo'")->fetchField();
+      $num_matches = db_query("SELECT count(*) FROM {test} WHERE job = :job", array(':job' => 'Musician'))->fetchField();
+      $person = db_query("SELECT * FROM {test} WHERE name=:name", array(':name' => 'Ringo'))->fetch();

some places it's field = value others field=value

A first round of fixes:
- Add t() to assertion messages, wrapped with single quotes where appropriate and sentences ending with a period.
- Remove empty setUp() calls.
- Fixed indentation in a few places.

All tests still pass.

Question:
Generally, the call to parent::tearDown() should be at the end of tearDown(), but doing so causes the test to throw uncaught exceptions (the tests still pass).

The problem with the tearDown() function was duplicate code between DatabaseTestCase::tearDown() and DrupalWebTestCase::tearDown(). Deleting the test tables (test, test_people, test_one_blob, test_two_blob and test_task) in DatabaseTestCase::tearDown() is not necessary as those tables are deleted automatically by the parent method.

Only difference with previous patch is the absence of tearDown() method.

Fixed the inconsistency pointed out in #6 (chose field = value).

Thanks, flobruit!

The attached patch is the same as #9 except with a few whitespace changes to make the coding style of chained methods a little tighter.

All tests passed!

PHP shows a notice though:

[31-Aug-2008 12:59:00] PHP Notice:  Undefined property:  stdClass::$age in /xxxx/modules/simpletest/tests/database_test.test on line 1308

Apache/2.0.59
PHP Version 5.2.5
MySQL 5.0.41

100% pass for me in conjunction with #297860: Regression: Convert session.inc to the new database API (and _sess_write should use a merge)

Now with additional comments!

Committed! :D

D'oh. :P Committed too soon.

Undefined property: stdClass::$age Notice database_test.test 1485

Tests do not finish on PostgreSQL. Edit: PostgreSQL 8.1

"testInsertFieldOnlyDefinition" gives "Uncaught exception" error.

Adding a try-catch statement allows tests to finish.

Oopsies. Try this.

Ok, I committed Crell's small notice fix. mustafu's could use review.

The main bulk of this patch is already in, so can we file a separate issue for the cleanup? I much prefer that to fixing and re-opening an issue over and over again. Thanks.