Download & Extend
Issues

Tests needed mail.inc

Posted by cwgordon7 on June 29, 2008 at 6:31pm
Project:Drupal core
Version:7.x-dev
Component:base system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:
Default site mail-from setting.

Login or register to post comments

Comments

#1

Posted by p.brouwers on July 2, 2008 at 7:14am
Assigned to:Anonymous» p.brouwers

I'm interested in doing these tests.

#2

Posted by catch on August 23, 2008 at 8:49pm
Title:Tests needed: mail.inc» TestingParty08: default site mail settings
Assigned to:p.brouwers» Anonymous

Opening up for the testing party.

#3

Posted by p.brouwers on August 25, 2008 at 12:24pm

I was busy writing the 4 mail tests in one .test file, but I see you've divided it into 4 different tests.

I've cleanup the files and left only this test in it.
I named it 'mail', I hope that's correct.

Should the other mail tests be in another file?

AttachmentSizeStatusTest resultOperations
tests.patch2.58 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch tests_0.patch.View details | Re-test

#4

Posted by catch on August 25, 2008 at 12:47pm
Title:TestingParty08: default site mail settings» Tests needed mail.inc
Status:active» needs review

Hi p.brouwers The split is pretty arbitrary due to the testing party at Drupalcon next week. If you've got a full test for this, please post it here and we can close out the other issues.

#5

Posted by p.brouwers on August 27, 2008 at 9:30am

ah ok.
I still need to write a test for CustomBackends. I'm not really familiar with that, so I don't know how long that'll take.

#6

Posted by Rob Loach on November 7, 2008 at 11:48pm

#331180: fix pluggable smtp/mail framework introduces a nice pluggable mail system as well as a test for it, should this issue be merged in with it?

#7

Posted by System Message on November 16, 2008 at 9:45pm
Status:needs review» needs work

The last submitted patch failed testing.

#8

Posted by lilou on November 17, 2008 at 2:18pm
Status:needs work» needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

#9

Posted by catch on November 19, 2008 at 1:15am
Status:needs review» needs work

We no longer have phpdoc for setUp(), getInfo() or tearDown()
http://drupal.org/node/325974

#10

Posted by Rob Loach on December 7, 2008 at 11:10pm
Status:needs work» postponed

Postponed until #331180: fix pluggable smtp/mail framework is in.

#11

Posted by Jax on September 5, 2009 at 1:36pm
Component:tests» base system

Referenced issue was committed. A mail.test file has already been created. I'm not sure if this is still relevant. Can someone confirm this can be closed?

#12

Posted by Stevel on June 23, 2010 at 9:20am
Priority:critical» normal
Status:postponed» needs work

The tests seem complementary, so these tests can be added, but should probably be integrated in the existing mail.test file.

#13

Posted by Chethan K on July 17, 2010 at 5:32pm
Status:needs work» needs review

#3: tests.patch queued for re-testing.

#14

Posted by System Message on July 17, 2010 at 5:50pm
Status:needs review» needs work

The last submitted patch, tests.patch, failed testing.

#15

Posted by p.brouwers on July 22, 2010 at 12:03pm
Status:needs work» needs review

updated patch for latest version of D7

AttachmentSizeStatusTest resultOperations
tests_v2.patch2.38 KBIdlePASSED: [[SimpleTest]]: [MySQL] 22,151 pass(es).View details | Re-test

#16

Posted by aspilicious on July 22, 2010 at 12:10pm
Status:needs review» needs work

+    $this->assertIdentical($default_from, $message['headers']['From'], t('testing equality of default-from setting'));
+  }
+}
\ No newline at end of file

Add a newline to remove that message

#17

Posted by p.brouwers on August 4, 2010 at 11:05am
Status:needs work» needs review

added the newline

AttachmentSizeStatusTest resultOperations
tests_v3.patch2.35 KBIdlePASSED: [[SimpleTest]]: [MySQL] 22,622 pass(es).View details | Re-test
nobody click here