Download & Extend
Issues

TestingParty08: custom_url_rewrite_inbound()

Posted by cwgordon7 on June 29, 2008 at 7:05pm
Project:Drupal core
Version:7.x-dev
Component:base system
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:

1) custom_url_rewrite_inbound().
2) drupal_match_path().

Login or register to post comments

Comments

#1

Posted by catch on August 10, 2008 at 3:53pm
Title:Tests needed: path.inc» TestingParty08: custom_url_rewrite_inbound()

#293496: TestingParty08: drupal_match_path() is now over there.

So restricting this to custom_url_rewrite_inbound()

Not sure how this'll work given that function has to be in settings.php

#2

Posted by chx on August 17, 2008 at 8:25am

It can be in a modules that implements hook_boot (even an empty hook_boot function will do). Those are loaded during DRUPAL_BOOTSTRAP_LATE_PAGE_CACHE and DRUPAL_BOOTSTRAP_PATH is a later stage.

#3

Posted by ThiOz on October 9, 2008 at 3:12pm
Priority:critical» normal
Status:active» needs review

Hi Guys,

Yusuf and i created a test for this function. It hasn't been reviewed yet.

AttachmentSizeStatusTest resultOperations
custom_rewrite_url_inbound.patch2.43 KBIdlePassed: 7207 passes, 0 fails, 0 exceptionsView details | Re-test

#4

Posted by spatz4000 on October 9, 2008 at 3:33pm
Priority:normal» critical

#5

Posted by Dries on October 9, 2008 at 8:33pm

Mmm, testNoPath() doesn't seem to be called anywhere?

#6

Posted by ThiOz on October 10, 2008 at 8:34am

Good point

I thought is was necessary to include the custom_rewrite_url_inbound.inc file but after some testing I found out that is not the case,
I will post the updated patch asap

Cheers Rob

#7

Posted by benshell on October 12, 2008 at 2:29am

I updated the text strings in the patch to follow conventions, and I moved the custom_rewrite_url_inbound.inc include into the test function where it's needed.

AttachmentSizeStatusTest resultOperations
custom_rewrite_url_inbound.patch2.52 KBIdlePassed: 7207 passes, 0 fails, 0 exceptionsView details | Re-test

#8

Posted by ThiOz on October 16, 2008 at 12:31pm

Hi Benshell,

I reviewed the patch and changed a couple of things to make it more in the Drupal codestyle and I added the include in the third testfunction to be sure that the function exists and really cannot be matched.

I posted the patch for reviewing.

Cheers

AttachmentSizeStatusTest resultOperations
custom_rewrite_url_inbound_test.patch3.1 KBIdleFailed: Failed to run tests.View details | Re-test

#9

Posted by Dries on October 16, 2008 at 9:26pm
Status:needs review» needs work

1. the custom_url_rewrite_inbound(). function -- the point is not in the right spot.

2. There are still some code-style issues. We changed the rules around string concatenation.

Should be a quick and easy re-roll.

#10

Posted by ThiOz on October 30, 2008 at 1:04pm
Status:needs work» needs review

Hi,

I checked the codestyle again ... I wasn't aware that the concat rules were changed, I was just getting the hang of the old style.

I added the new patch

Cheers

AttachmentSizeStatusTest resultOperations
custom_url_rewrite_inbound_test.patch3.13 KBIdlePassed: 7204 passes, 0 fails, 0 exceptionsView details | Re-test

#11

Posted by ThiOz on November 6, 2008 at 2:30pm

Hi,

I saw that the patches weren't made correctly, I made a new one.

cheers

AttachmentSizeStatusTest resultOperations
drupal_custom_rewrite_url_inbound_test.patch2.58 KBIdleFailed: Failed to apply patch.View details | Re-test

#12

Posted by Anonymous (not verified) on November 13, 2008 at 12:50pm
Status:needs review» needs work

The last submitted patch failed testing.

#13

Posted by catch on October 17, 2009 at 7:36am
Component:tests» base system
Category:bug report» task
Priority:critical» normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.