TestingParty08: custom_url_rewrite_inbound()

#293496: TestingParty08: drupal_match_path() is now over there.

So restricting this to custom_url_rewrite_inbound()

Not sure how this'll work given that function has to be in settings.php

It can be in a modules that implements hook_boot (even an empty hook_boot function will do). Those are loaded during DRUPAL_BOOTSTRAP_LATE_PAGE_CACHE and DRUPAL_BOOTSTRAP_PATH is a later stage.

Hi Guys,

Yusuf and i created a test for this function. It hasn't been reviewed yet.

Mmm, testNoPath() doesn't seem to be called anywhere?

Good point

I thought is was necessary to include the custom_rewrite_url_inbound.inc file but after some testing I found out that is not the case,
I will post the updated patch asap

Cheers Rob

I updated the text strings in the patch to follow conventions, and I moved the custom_rewrite_url_inbound.inc include into the test function where it's needed.

Hi Benshell,

I reviewed the patch and changed a couple of things to make it more in the Drupal codestyle and I added the include in the third testfunction to be sure that the function exists and really cannot be matched.

I posted the patch for reviewing.

Cheers

1. the custom_url_rewrite_inbound(). function -- the point is not in the right spot.

2. There are still some code-style issues. We changed the rules around string concatenation.

Should be a quick and easy re-roll.

Hi,

I checked the codestyle again ... I wasn't aware that the concat rules were changed, I was just getting the hang of the old style.

I added the new patch

Cheers

Hi,

I saw that the patches weren't made correctly, I made a new one.

cheers

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.