This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:

1) tablesort_header() with an existing cell class.
2) tablesort_header() with an existing query string.
3) Actual tablesorting.

CommentFileSizeAuthor
#11 tablesort_tests_01.patch2.21 KBcwgordon7
#9 common.test.20080901.tablesort.patch2.01 KBlilou
#7 common.test.20080831.tablesort.patch1.91 KBlilou
#3 common.test.20080828.tablesort.patch1.84 KBSeeSchloss

Comments

Wisif’s picture

Wisif commented
Assigned: Unassigned » Wisif

I expect within 3 weeks to test

catch’s picture

catch
he/him
Primary language English
commented
Title: Tests needed: tablesort.inc » TestingParty08: tablesort.inc
Assigned: Wisif » Unassigned

Opening this up for the testing party.

SeeSchloss’s picture

SeeSchloss commented
StatusFileSize
new common.test.20080828.tablesort.patch1.84 KB

Tests for 1 and 2

ekes and SeeSchloss

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review

Patch failed to apply. More information can be found at http://testing.drupal.org/node/13893. If you need help with creating patches please look at http://drupal.org/patch/create

dries’s picture

dries commented
Status: Needs review » Needs work
lilou’s picture

lilou commented
Status: Needs work » Needs review
StatusFileSize
new common.test.20080831.tablesort.patch1.91 KB
cwgordon7’s picture

cwgordon7 commented
Assigned: Unassigned » cwgordon7
Status: Needs review » Needs work

Various tabs in various places, coding standards generally needs work on this.

lilou’s picture

lilou commented
Status: Needs work » Needs review
StatusFileSize
new common.test.20080901.tablesort.patch2.01 KB

Clean patch.

lilou’s picture

lilou commented
Status: Needs review » Needs work

Miss 3)

cwgordon7’s picture

cwgordon7 commented
Status: Needs work » Needs review
StatusFileSize
new tablesort_tests_01.patch2.21 KB

Re-rolled, 4 passes, 0 fails, 0 exceptions.

cwgordon7’s picture

cwgordon7 commented

Note that these are unit tests, it would be great to have functional tests too eventually.

cwgordon7’s picture

cwgordon7 commented

Meh. Cross-posted, apologies.

moshe weitzman’s picture

moshe weitzman commented

Seems like we could test this whenever we test admin/content/node or similar page.

chrisshattuck’s picture

chrisshattuck commented
Status: Needs review » Needs work

Sorry, trying to figure out patching, made a little mistake and didn't patch it properly.

chrisshattuck’s picture

chrisshattuck commented
Status: Needs work » Needs review

Switched status previously based on a bad patch experience. Switching it back to review.

chrisshattuck’s picture

chrisshattuck commented
Status: Needs review » Reviewed & tested by the community

Patched and ran test successfully:
4 passes, 0 fails, 0 exceptions

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Since this is a testing party patch, I'm going to be mercilessly nit-picky in this review. It's only because I care. :)

This one was actually hard. :P I had to think about it for awhile.

+    $ts = array('name' => '', 'sort' => 'asc', 'query_string' => '');

a) I realize it's easy enough to deduce that $ts == $tablesort, but it'd be nice to be explicit about that fact. Needs changing throughout.
b) Coding standards dictate each of these on their own lines. However, this is consistent with the way table-related arrays are done so I'm leaving it alone for now.

+    $this->assertEqual($new_cell['class'], 'red active');

Red active? What does that mean? Could you add a message parameter here with more specifics about what's being tested? The general rule of thumb is that by reading the output of the messages in SimpleTest module, we can learn what the test run tested for. This advice applies throughout.

+    $this->assertEqual($new_cell['class'], 'active');

Same here.

+   * Tests the handling of additional query strings by Druapl's tablesort API.

What's Druapl? :)

catch’s picture

catch
he/him
Primary language English
commented
Component: tests » base system
Category: bug » task
Priority: Critical » Normal

Fixing the critical / pending bugs queues to reflect things which are really bugs or release critical.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.