Blocks from other modules are emptied
Arancaytar - June 30, 2008 - 00:02
| Project: | DHTML Menu |
| Version: | 6.x-2.x-dev |
| Component: | PHP Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Arancaytar |
| Status: | closed |
Description
This is a pretty stupid issue, and I'm wondering how it is nobody else has caught it so far.
Steps to reproduce:
1.) Put DHTML on all your menu blocks.
2.) Create a custom block. Make sure that the custom block has the same delta value as that of a menu block (ie, they're identified by block:{n} and menu:{n})
Expected result:
The custom block is displayed normally.
Actual result:
The content is stripped from the custom block.
Diagnosis:
DHTML Menu needs to identify blocks by module as well as delta. I have a patch here that fixes this, including an update hook.
#1
Here we go. There's a bit of a concept issue involved here. The module index is missing because the settings are stored per menu name rather than per block:delta. This breaks because what is being replaced is a block, not a menu.
Perhaps a future version can interface with the Menu API rather than the Block API, but for now we have to use block:delta instead of the menu name to index these settings.
#2
Committed.
This is the first bug to be fixed since the last release. (Just keeping track.)
#3
Automatically closed -- issue fixed for two weeks with no activity.