This is a pretty stupid issue, and I'm wondering how it is nobody else has caught it so far.

Steps to reproduce:

1.) Put DHTML on all your menu blocks.
2.) Create a custom block. Make sure that the custom block has the same delta value as that of a menu block (ie, they're identified by block:{n} and menu:{n})

Expected result:

The custom block is displayed normally.

Actual result:

The content is stripped from the custom block.

Diagnosis:

DHTML Menu needs to identify blocks by module as well as delta. I have a patch here that fixes this, including an update hook.

CommentFileSizeAuthor
#1 dhtml_menu-block-delta-276507-1.patch4.72 KBcburschka

Comments

cburschka’s picture

Status: Active » Needs review
StatusFileSize
new4.72 KB

Here we go. There's a bit of a concept issue involved here. The module index is missing because the settings are stored per menu name rather than per block:delta. This breaks because what is being replaced is a block, not a menu.

Perhaps a future version can interface with the Menu API rather than the Block API, but for now we have to use block:delta instead of the menu name to index these settings.

cburschka’s picture

Status: Needs review » Fixed

Committed.

This is the first bug to be fixed since the last release. (Just keeping track.)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.