During testing of current CVS code I noted that trying to delete a user has no effect. Whether it is a good idea to delete users is another question (see http://drupal.org/node/19055)...

in modules/user.module:user_edit(), when the admin clicks on the "Delete" button at the end of a user's page, this happens:

drupal_goto("user/$account->uid/delete");

Unfortunately, at least in my situation, the GET variable "destination" was set to "admin/user", so what drupal_goto() does is use this address rather than the parameter it receives. The net effect is that when you click Delete you end up on the user admin page again.

The obvious fix seems to unset() the destination, see enclosed patch.

CommentFileSizeAuthor
#2 user_delete_1.patch587 bytesUwe Hermann
user_delete.path447 byteswiz-1

Comments

Tobias Maier’s picture

saw the same problem
please fix it
Thanks

Uwe Hermann’s picture

Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new587 bytes

I can confirm this bug. It's critical IMHO. The patch seems broken, so here's a rerolled one for HEAD which works for me. Please test.

Steve Dondley’s picture

Status: Needs review » Closed (fixed)

Can't reproduce. This problem seems to have been resolved.

chx’s picture

Status: Closed (fixed) » Fixed

Steve, fixed is fixed, please do not close by hand.

Anonymous’s picture

Status: Fixed » Closed (fixed)