This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:

1) Attempt to perform an operation on no selected comments.
2) Attempt to view the admin overview form with no comments posted.
3) View enough comments on the administration overview form so that it spans several pages.
4) Attempting to delete nonexistent comments (admin).
5) Attempting to delete a nonexitent comment.

CommentFileSizeAuthor
#5 276523_fixing_comment_tests.patch3.38 KBaspilicious
#3 comment-276523.patch3.55 KBTUc

Comments

catch’s picture

catch
he/him
Primary language English
commented
Title: Tests needed: comment.admin.inc » TestingParty08: Comment administration
TUc’s picture

TUc commented
Component: tests » comment.module

I'm taking this one.

TUc’s picture

TUc commented
Assigned: Unassigned » TUc
Status: Active » Needs work
StatusFileSize
new comment-276523.patch3.55 KB

Here's a patch for issues 1, 2, 4 and 5. The third failed, because of a bug in Drupal 7 Core. No pager is generated on the comment admin page, no matter how many comments are saved. I'll file an issue for that...

TUc

catch’s picture

catch
he/him
Primary language English
commented
Category: bug » task
Priority: Critical » Normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
StatusFileSize
new 276523_fixing_comment_tests.patch3.38 KB

Reroll, tests failed localy but my knowledge isn't big enough to fix them :).
At least it applies again ;)
1-5 are possible now.

So if the tests works this one is ready.

Status: Needs review » Needs work

The last submitted patch, 276523_fixing_comment_tests.patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.