This information is from the code coverage report (see http://coverage.cwgordon.com/coverage).

We need to test:

1) Auto-completing
2) Requesting a new password (can use mail.inc override to intercept the e-mail)
3) Editing a user (with malicious values and without)

Comments

catch’s picture

Title: Tests needed: user.pages.inc » TestingParty08: Editing a user (with and without malicious/duplicate values)

Splitting into three for the awesome testing party, so this only deals with #3 in the original list.

The other two tests are here:
#293487: TestingParty08: User password reset #293490: User autocomplete gives 403 errors with certain combinations of permissions

p.brouwers’s picture

Assigned: Unassigned » p.brouwers
Status: Active » Needs review
StatusFileSize
new3.22 KB

I made some basic tests for "Editing a user (with malicious values and without)"

It can be expanded it bit more, but it's a start.

Status: Needs review » Needs work

The last submitted patch failed testing.

p.brouwers’s picture

Status: Needs work » Needs review
catch’s picture

Category: bug » task
Status: Needs review » Needs work

Looks like a good start. A few things though - getInfo() no longer has PHPdoc - see http://drupal.org/node/325974. Also a few comments in there should be formatted as full sentences with a space after the //. I'm also not sure about testing for the lack of <div class="message" - any particular reason to do this rather than the specific text?

p.brouwers’s picture

Component: tests » user system
Status: Needs work » Needs review
StatusFileSize
new3.46 KB

I made the adjustments as you suggested.
(hope I set the right Component)

Status: Needs review » Needs work

The last submitted patch failed testing.

p.brouwers’s picture

Status: Needs work » Needs review
StatusFileSize
new3.46 KB

resubmitted patch, head was broken when test was run

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

Status: Needs work » Needs review
StatusFileSize
new3.51 KB

Now, t() is removed in getinfo() : #500866: [META] remove t() from assert message

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

Priority: Critical » Normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

jacob.embree’s picture

Assigned: p.brouwers » Unassigned
Issue summary: View changes
Status: Needs work » Closed (duplicate)

All of these tests are present.